From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1dIFPr-0001XF-G3
	for qemu-devel@nongnu.org; Tue, 06 Jun 2017 10:25:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1dIFPp-0006AF-9F
	for qemu-devel@nongnu.org; Tue, 06 Jun 2017 10:25:03 -0400
Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:38509)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <alex.bennee@linaro.org>)
	id 1dIFPp-000699-3A
	for qemu-devel@nongnu.org; Tue, 06 Jun 2017 10:25:01 -0400
Received: by mail-wm0-x22c.google.com with SMTP id n195so101941061wmg.1
	for <qemu-devel@nongnu.org>; Tue, 06 Jun 2017 07:25:01 -0700 (PDT)
References: <20170602160848.4913-1-alex.bennee@linaro.org>
	<20170602160848.4913-10-alex.bennee@linaro.org>
	<CAFEAcA81E8LTdQjMHypTZwEueoytJ2n1_C9ofwJmZ=esU++c+g@mail.gmail.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <CAFEAcA81E8LTdQjMHypTZwEueoytJ2n1_C9ofwJmZ=esU++c+g@mail.gmail.com>
Date: Tue, 06 Jun 2017 15:25:24 +0100
Message-ID: <87mv9lchwr.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [RISU PATCH v4 09/10] new: record_traces.sh helper
 script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>


Peter Maydell <peter.maydell@linaro.org> writes:

> On 2 June 2017 at 17:08, Alex Bennée <alex.bennee@linaro.org> wrote:
>> A simple script to run through a bunch of binaries and generate their
>> trace files.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>> ---
>> v3
>>   - allow overriding of RISU binary
>> ---
>>  record_traces.sh | 20 ++++++++++++++++++++
>>  1 file changed, 20 insertions(+)
>>  create mode 100755 record_traces.sh
>>
>> diff --git a/record_traces.sh b/record_traces.sh
>> new file mode 100755
>> index 0000000..78ce47f
>> --- /dev/null
>> +++ b/record_traces.sh
>> @@ -0,0 +1,20 @@
>> +#!/bin/sh
>> +#
>> +# Record traces
>> +#
>> +# A risu helper script to batch process a bunch of binaries and record their outputs
>> +#
>
> Can we have a license statement, copyright line and a
> usage summary, please? (Ditto patch 10). I'm not sure if
> these scripts are intended for testing purposes or as
> something that risu users might want to use -- if the
> latter then also documenting them in README would be
> a good idea.

They are more useful scripts I used for bulk generating stuff. Maybe I
should move them into contrib?

I'll update the usage and copyright lines.

>
>> +set -e
>> +
>> +if test -z "$RISU"; then
>> +    script_dir=$(CDPATH= cd -- "$(dirname -- "$0")" && pwd -P)
>> +    RISU=${script_dir}/risu
>> +fi
>> +
>> +for f in $@; do
>> +    echo "Running risu against $f"
>> +    t="$f.trace"
>> +    ${RISU} --master $f -t $t
>> +    echo "Checking trace file OK"
>> +    ${RISU} $f -t $t
>> +done
>> --
>> 2.13.0
>
> thanks
> -- PMM


--
Alex Bennée