All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: Move check_migratable() into qdev.c
Date: Thu, 11 May 2017 16:46:28 +0200	[thread overview]
Message-ID: <87mvajh2nv.fsf@secure.mitica> (raw)
In-Reply-To: <20170511143901.6340-1-quintela@redhat.com> (Juan Quintela's message of "Thu, 11 May 2017 16:39:01 +0200")

Juan Quintela <quintela@redhat.com> wrote:
> The function is only used once, and nothing else in migration knows
> about objects.  Create the function vmstate_device_is_migratable() in
> savem.c that really do the bit that is related with migration.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>

Hi, I forget to "add" the comments section.

I switched to Peter Xu idea of only testing ->unmigratable is savevm.c
and move the only_migratable check to qdev.c.

Once there, change the return types from -1/0 to true/false and improve
slightly the naming.

Please, comment.

  reply	other threads:[~2017-05-11 14:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11 14:39 [Qemu-devel] [PATCH] migration: Move check_migratable() into qdev.c Juan Quintela
2017-05-11 14:46 ` Juan Quintela [this message]
2017-05-11 15:09 ` Dr. David Alan Gilbert
2017-05-11 15:24 ` no-reply
2017-05-11 15:27   ` Dr. David Alan Gilbert
2017-05-11 15:37     ` Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvajh2nv.fsf@secure.mitica \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.