From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: disable KASAN for handlers Date: Fri, 31 Mar 2017 13:29:18 +0300 Message-ID: <87mvc13fk1.fsf@intel.com> References: <20170330094627.29460-1-jslaby@suse.cz> <20170331072148.lbb7x6tj5egkpppm@zhen-hp.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170331072148.lbb7x6tj5egkpppm@zhen-hp.sh.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Zhenyu Wang , Jiri Slaby Cc: Arnd Bergmann , Martin Liska , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , intel-gvt-dev@lists.freedesktop.org, Zhi Wang List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAzMSBNYXIgMjAxNywgWmhlbnl1IFdhbmcgPHpoZW55dXdAbGludXguaW50ZWwuY29t PiB3cm90ZToKPiBPbiAyMDE3LjAzLjMwIDExOjQ2OjI3ICswMjAwLCBKaXJpIFNsYWJ5IHdyb3Rl Ogo+PiBIYW5kbGVycyBhcmUgY3VycmVudGx5IHRoZSBvbmx5IGJsb2NrZXIgdG8gY29tcGlsZSB0 aGUga2VybmVsIHdpdGggZ2NjIDcKPj4gYW5kIEtBU0FOK3VzZS1hZnRlci1zY29wZSBlbmFibGVk Ogo+PiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQvaGFuZGxlcnMuYzoyMjAwOjE6IGVycm9yOiB0 aGUgZnJhbWUgc2l6ZSBvZiA0Mzc2MCBieXRlcyBpcyBsYXJnZXIgdGhhbiAyMDQ4IGJ5dGVzIFst V2Vycm9yPWZyYW1lLWxhcmdlci10aGFuPV0KPj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2hh bmRsZXJzLmM6MjQwMjoxOiBlcnJvcjogdGhlIGZyYW1lIHNpemUgb2YgOTQwMCBieXRlcyBpcyBs YXJnZXIgdGhhbiAyMDQ4IGJ5dGVzIFstV2Vycm9yPWZyYW1lLWxhcmdlci10aGFuPV0KPj4gZHJp dmVycy9ncHUvZHJtL2k5MTUvZ3Z0L2hhbmRsZXJzLmM6MjYyODoxOiBlcnJvcjogdGhlIGZyYW1l IHNpemUgb2YgMTEyNTYgYnl0ZXMgaXMgbGFyZ2VyIHRoYW4gMjA0OCBieXRlcyBbLVdlcnJvcj1m cmFtZS1sYXJnZXItdGhhbj1dCj4+IAo+PiBJdCBpcyBkdWUgdG8gbWFueSBleHBhbnNpb25zIG9m IE1NSU9fKiBtYWNyb3MgaW4gaW5pdF9nZW5lcmljX21taW9faW5mby4KPj4gSU5URUxfR1ZUX01N SU9fT0ZGU0VUIGdlbmVyYXRlcyBmb3IgZWFjaCBzdWNoIGxpbmUgYSBfX3JlZyBhbmQgYW4KPj4g b2Zmc2V0LiBUaGVyZSBhcmUgdG9vIG1hbnkgZm9yIEtBU0FOIHRvIGtlZXAgdXAuCj4+IAo+PiBT byBkaXNhYmxlIEtBU0FOIGZvciB0aGlzIGZpbGUuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBKaXJp IFNsYWJ5IDxqc2xhYnlAc3VzZS5jej4KPj4gQ2M6IE1hcnRpbiBMaXNrYSA8bWxpc2thQHN1c2Uu Y3o+Cj4+IENjOiBaaGVueXUgV2FuZyA8emhlbnl1d0BsaW51eC5pbnRlbC5jb20+Cj4+IENjOiBa aGkgV2FuZyA8emhpLmEud2FuZ0BpbnRlbC5jb20+Cj4+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5p ZWwudmV0dGVyQGludGVsLmNvbT4KPj4gQ2M6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3VsYUBsaW51 eC5pbnRlbC5jb20+Cj4+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4+IENj OiBpbnRlbC1ndnQtZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBDYzogaW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+PiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+PiAtLS0KPj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9NYWtlZmlsZSB8IDIgKysKPj4g IDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9ndnQvTWFrZWZpbGUgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9ndnQv TWFrZWZpbGUKPj4gaW5kZXggYjEyM2MyMGUyMDk3Li45NDJmMTg0OWQxOTQgMTAwNjQ0Cj4+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2d2dC9NYWtlZmlsZQo+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vaTkxNS9ndnQvTWFrZWZpbGUKPj4gQEAgLTYsMyArNiw1IEBAIEdWVF9TT1VSQ0UgOj0g Z3Z0Lm8gYXBlcnR1cmVfZ20ubyBoYW5kbGVycy5vIHZncHUubyB0cmFjZV9wb2ludHMubyBmaXJt d2FyZS5vIFwKPj4gIGNjZmxhZ3MteQkJCQkrPSAtSSQoc3JjKSAtSSQoc3JjKS8kKEdWVF9ESVIp IC1XYWxsCj4+ICBpOTE1LXkJCQkJCSs9ICQoYWRkcHJlZml4ICQoR1ZUX0RJUikvLCAkKEdWVF9T T1VSQ0UpKQo+PiAgb2JqLSQoQ09ORklHX0RSTV9JOTE1X0dWVF9LVk1HVCkJKz0gJChHVlRfRElS KS9rdm1ndC5vCj4+ICsKPj4gK0tBU0FOX1NBTklUSVpFX2hhbmRsZXJzLm8gOj0gbgo+PiAtLSAK Pj4gMi4xMi4yCj4+IAo+Cj4gQXBwbGllZCB0aGlzLCB3ZSdkIGJldHRlciBjbGVhbnVwIGxlZ2Fj eSB1c2FnZSB0byBjdXJyZW50IGk5MTUgbW1pbwo+IHJlZyBkZWZpbmUuIFRoYW5rcyEKCkhtbWgs IHRoYXQgd2FzIGEgYml0IGZhc3QsIHRoZXJlIHdhcyBhIHJlbGF0ZWQgZGlzY3Vzc2lvbiBnb2lu ZyBpbiBbMV0uCgpCUiwKSmFuaS4KCgpbMV0gaHR0cDovL21pZC5tYWlsLWFyY2hpdmUuY29tLzIw MTcwMzIwMjE1NzEzLjMwODYxNDAtMS1hcm5kQGFybmRiLmRlCgoKCgotLSAKSmFuaSBOaWt1bGEs IEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933063AbdCaK3Y (ORCPT ); Fri, 31 Mar 2017 06:29:24 -0400 Received: from mga11.intel.com ([192.55.52.93]:52236 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932781AbdCaK3X (ORCPT ); Fri, 31 Mar 2017 06:29:23 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,251,1486454400"; d="scan'208";a="840364325" From: Jani Nikula To: Zhenyu Wang , Jiri Slaby Cc: linux-kernel@vger.kernel.org, Martin Liska , Zhi Wang , Daniel Vetter , David Airlie , intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Arnd Bergmann Subject: Re: [PATCH] drm/i915: disable KASAN for handlers In-Reply-To: <20170331072148.lbb7x6tj5egkpppm@zhen-hp.sh.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20170330094627.29460-1-jslaby@suse.cz> <20170331072148.lbb7x6tj5egkpppm@zhen-hp.sh.intel.com> Date: Fri, 31 Mar 2017 13:29:18 +0300 Message-ID: <87mvc13fk1.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 31 Mar 2017, Zhenyu Wang wrote: > On 2017.03.30 11:46:27 +0200, Jiri Slaby wrote: >> Handlers are currently the only blocker to compile the kernel with gcc 7 >> and KASAN+use-after-scope enabled: >> drivers/gpu/drm/i915/gvt/handlers.c:2200:1: error: the frame size of 43760 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2402:1: error: the frame size of 9400 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> drivers/gpu/drm/i915/gvt/handlers.c:2628:1: error: the frame size of 11256 bytes is larger than 2048 bytes [-Werror=frame-larger-than=] >> >> It is due to many expansions of MMIO_* macros in init_generic_mmio_info. >> INTEL_GVT_MMIO_OFFSET generates for each such line a __reg and an >> offset. There are too many for KASAN to keep up. >> >> So disable KASAN for this file. >> >> Signed-off-by: Jiri Slaby >> Cc: Martin Liska >> Cc: Zhenyu Wang >> Cc: Zhi Wang >> Cc: Daniel Vetter >> Cc: Jani Nikula >> Cc: David Airlie >> Cc: intel-gvt-dev@lists.freedesktop.org >> Cc: intel-gfx@lists.freedesktop.org >> Cc: dri-devel@lists.freedesktop.org >> --- >> drivers/gpu/drm/i915/gvt/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/gvt/Makefile b/drivers/gpu/drm/i915/gvt/Makefile >> index b123c20e2097..942f1849d194 100644 >> --- a/drivers/gpu/drm/i915/gvt/Makefile >> +++ b/drivers/gpu/drm/i915/gvt/Makefile >> @@ -6,3 +6,5 @@ GVT_SOURCE := gvt.o aperture_gm.o handlers.o vgpu.o trace_points.o firmware.o \ >> ccflags-y += -I$(src) -I$(src)/$(GVT_DIR) -Wall >> i915-y += $(addprefix $(GVT_DIR)/, $(GVT_SOURCE)) >> obj-$(CONFIG_DRM_I915_GVT_KVMGT) += $(GVT_DIR)/kvmgt.o >> + >> +KASAN_SANITIZE_handlers.o := n >> -- >> 2.12.2 >> > > Applied this, we'd better cleanup legacy usage to current i915 mmio > reg define. Thanks! Hmmh, that was a bit fast, there was a related discussion going in [1]. BR, Jani. [1] http://mid.mail-archive.com/20170320215713.3086140-1-arnd@arndb.de -- Jani Nikula, Intel Open Source Technology Center