From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/2] drm/i915/vbt: split out defaults that are set when there is no VBT Date: Tue, 14 Mar 2017 11:09:01 +0200 Message-ID: <87mvcotec2.fsf@intel.com> References: <95c26079ff640d43f53b944f17e9fc356b36daec.1489152288.git.jani.nikula@intel.com> <20170310235759.GB3175@intel.com> <87lgs9fqlo.fsf@intel.com> <20170313163009.GA8626@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 008196E024 for ; Tue, 14 Mar 2017 09:09:09 +0000 (UTC) In-Reply-To: <20170313163009.GA8626@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAxMyBNYXIgMjAxNywgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVs LmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBNYXIgMTMsIDIwMTcgYXQgMTE6NTU6MzFBTSArMDIwMCwg SmFuaSBOaWt1bGEgd3JvdGU6Cj4+IE9uIFNhdCwgMTEgTWFyIDIwMTcsIE1hbmFzaSBOYXZhcmUg PG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+IHdyb3RlOgo+PiA+IE9uIEZyaSwgTWFyIDEwLCAy MDE3IGF0IDAzOjI3OjU4UE0gKzAyMDAsIEphbmkgTmlrdWxhIHdyb3RlOgo+PiA+PiBUaGUgbWFp biB0aGluZyBhcmUgdGhlIERESSBwb3J0cy4gSWYgdGhlcmUncyBhIFZCVCB0aGF0IHNheXMgdGhl cmUgYXJlCj4+ID4+IG5vIG91dHB1dHMsIHdlIHNob3VsZCB0cnVzdCB0aGF0LCBhbmQgbm90IGhh dmUgc2VtaS1yYW5kb20KPj4gPj4gZGVmYXVsdHMuIFVuZm9ydHVuYXRlbHksIHRoZSBkZWZhdWx0 cyBoYXZlIHJlc3VsdGVkIGluIHNvbWUgQ2hyb21lYm9va3MKPj4gPj4gd2l0aG91dCBWQlQgdG8g cmVseSBvbiB0aGlzIGJlaGF2aW91ciwgc28gd2Ugc3BsaXQgb3V0IHRoZSBkZWZhdWx0cyBmb3IK Pj4gPj4gdGhlIG1pc3NpbmcgVkJUIGNhc2UuCj4+ID4+IAo+PiA+PiBDYzogTWFuYXNpIE5hdmFy ZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPj4gPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4+ID4+IFNpZ25lZC1vZmYtYnk6IEphbmkg TmlrdWxhIDxqYW5pLm5pa3VsYUBpbnRlbC5jb20+Cj4+ID4+IC0tLQo+PiA+PiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jIHwgMTcgKysrKysrKysrKysrKysrKy0KPj4gPj4gIDEg ZmlsZSBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4+ID4+IAo+PiA+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4+ID4+IGluZGV4IDcxMDk4OGQ3MjI1My4uNjM5 ZDQ1YzFkZDJlIDEwMDY0NAo+PiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i aW9zLmMKPj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4+ID4+ IEBAIC0xMzQxLDYgKzEzNDEsNyBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5 MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ID4+ICAJcmV0dXJuOwo+PiA+PiAgfQo+PiA+PiAgCj4+ ID4+ICsvKiBDb21tb24gZGVmYXVsdHMgd2hpY2ggbWF5IGJlIG92ZXJyaWRkZW4gYnkgVkJULiAq Lwo+PiA+PiAgc3RhdGljIHZvaWQKPj4gPj4gIGluaXRfdmJ0X2RlZmF1bHRzKHN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdikKPj4gPj4gIHsKPj4gPj4gQEAgLTEzNzcsNiArMTM3OCwx OCBAQCBpbml0X3ZidF9kZWZhdWx0cyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYp Cj4+ID4+ICAJCQkmZGV2X3ByaXYtPnZidC5kZGlfcG9ydF9pbmZvW3BvcnRdOwo+PiA+PiAgCj4+ ID4+ICAJCWluZm8tPmhkbWlfbGV2ZWxfc2hpZnQgPSBIRE1JX0xFVkVMX1NISUZUX1VOS05PV047 Cj4+ID4+ICsJfQo+PiA+PiArfQo+PiA+PiArCj4+ID4+ICsvKiBEZWZhdWx0cyB0byBpbml0aWFs aXplIG9ubHkgaWYgdGhlcmUgaXMgbm8gVkJULiAqLwo+PiA+PiArc3RhdGljIHZvaWQKPj4gPj4g K2luaXRfdmJ0X21pc3NpbmdfZGVmYXVsdHMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w cml2KQo+PiA+PiArewo+PiA+PiArCWVudW0gcG9ydCBwb3J0Owo+PiA+PiArCj4+ID4+ICsJZm9y IChwb3J0ID0gUE9SVF9BOyBwb3J0IDwgSTkxNV9NQVhfUE9SVFM7IHBvcnQrKykgewo+PiA+PiAr CQlzdHJ1Y3QgZGRpX3ZidF9wb3J0X2luZm8gKmluZm8gPQo+PiA+PiArCQkJJmRldl9wcml2LT52 YnQuZGRpX3BvcnRfaW5mb1twb3J0XTsKPj4gPj4gIAo+PiA+PiAgCQlpbmZvLT5zdXBwb3J0c19k dmkgPSAocG9ydCAhPSBQT1JUX0EgJiYgcG9ydCAhPSBQT1JUX0UpOwo+PiA+PiAgCQlpbmZvLT5z dXBwb3J0c19oZG1pID0gaW5mby0+c3VwcG9ydHNfZHZpOwo+PiA+PiBAQCAtMTUxNiw4ICsxNTI5 LDEwIEBAIHZvaWQgaW50ZWxfYmlvc19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdikKPj4gPj4gIAlwYXJzZV9kZGlfcG9ydHMoZGV2X3ByaXYsIGJkYik7Cj4+ID4+ICAKPj4g Pj4gIG91dDoKPj4gPj4gLQlpZiAoIXZidCkKPj4gPj4gKwlpZiAoIXZidCkgewo+PiA+PiAgCQlE Uk1fSU5GTygiRmFpbGVkIHRvIGZpbmQgVkJJT1MgdGFibGVzIChWQlQpXG4iKTsKPj4gPj4gKwkJ aW5pdF92YnRfbWlzc2luZ19kZWZhdWx0cyhkZXZfcHJpdik7Cj4+ID4+ICsJfQo+PiA+Cj4+ID4g U28gaW4gY2FzZSB0aGVyZSBpcyBubyBWQlQsIHRoaXMgd2lsbCBzZXQgc3VwcG9ydHNfRFAgZmxh ZyBvbiBQb3J0IEEuCj4+ID4gV2hhdCBpcyB0aGVyZSBpcyBubyBWQlQgYW5kIHRoZXJlIGlzIG5v IGVEUCBvbiBQb3J0IEE/Cj4+ID4gSW4gdGhpcyBjYXNlIGl0IHdpbGwgc3RpbGwgdHJ5IHRvIGxp bmsgdHJhaW4gb24gUG9ydCBBIGFuZCBmYWlsLi4/Cj4+ID4gSSBhbSBub3Qgc3VyZSBpZiB0aGlz IGNhc2UgZXhpc3RzLCBidXQganVzdCBhIHRob3VnaHQgbG9va2luZyBhdCBpdC4KPj4gCj4+IEl0 J3MgcG9zc2libGUgdGhlIGNhc2UgZXhpc3RzLCBidXQgdGhlIHBvaW50IGlzIHRoYXQgdGhlIGJl aGF2aW91ciBmb3IKPj4gdGhlIG5vLVZCVCBjYXNlIHJlbWFpbnMgdGhlIHNhbWUgYmVmb3JlIGFu ZCBhZnRlciB0aGlzIHBhdGNoLgo+PiAKPj4gQlIsCj4+IEphbmkuCj4+IAo+Pgo+Cj4gT2sgYWdy ZWVkLiBJbiB0aGF0IGNhc2UgUmV2aWV3ZWQtYnk6IE1hbmFzaSBOYXZhcmUKPiA8bWFuYXNpLmQu bmF2YXJlQGludGVsLmNvbT4KClB1c2hlZCB0byBkcm0taW50ZWwtbmV4dC1xdWV1ZWQsIHRoYW5r cyBmb3IgdGhlIHJldmlldy4KCkkgcmVhbGx5IGhvcGUgdGhlcmUgYXJlIG5vIG1hY2hpbmVzIG91 dCB0aGVyZSB0aGF0IGhhdmUgYSBjcmlwcGxlZCBWQlQKd2l0aCBubyBjaGlsZCBkZXZpY2UgY29u ZmlnLiBJIGd1ZXNzIHdlJ2xsIGZpbmQgb3V0Li4uCgpCUiwKSmFuaS4KCgo+Cj4gUmVnYXJkcwo+ IE1hbmFzaQo+Cj4gIAo+PiA+IElmIHN1Y2ggYSBjYXNlIGRvZXMgbm90IGV4aXN0LCB0aGVuIHRo aXMgd2lsbCBzb2x2ZSBvdXIgcHJvYmxlbSBvZgo+PiA+IGN1cnJlbnQgZmFpbHVyZXMgYmVjYXVz ZSBsZWF2aW5nIGRlZmF1bHRzIG9uIFBvcnQgQS4gU28gaW4gdGhhdCBjYXNlCj4+ID4gaXQgbGd0 bS4KPj4gPgo+PiA+IFJlZ2FyZHMKPj4gPiBNYW5hc2kKPj4gPgo+PiA+Cj4+ID4+ICAKPj4gPj4g IAlpZiAoYmlvcykKPj4gPj4gIAkJcGNpX3VubWFwX3JvbShwZGV2LCBiaW9zKTsKPj4gPj4gLS0g Cj4+ID4+IDIuMS40Cj4+ID4+IAo+PiAKPj4gLS0gCj4+IEphbmkgTmlrdWxhLCBJbnRlbCBPcGVu IFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK