From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53750)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1buZgt-0002SU-Pp
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 02:40:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1buZgr-0005zI-R4
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 02:40:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37070)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1buZgr-0005z9-KJ
	for qemu-devel@nongnu.org; Thu, 13 Oct 2016 02:40:29 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 1E6B84DAF8
	for <qemu-devel@nongnu.org>; Thu, 13 Oct 2016 06:40:29 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <20161011174121.815-1-marcandre.lureau@redhat.com>
	<87a8ea693q.fsf@dusky.pond.sub.org> <20161012084626.GA2031@work-vm>
Date: Thu, 13 Oct 2016 08:40:27 +0200
In-Reply-To: <20161012084626.GA2031@work-vm> (David Alan Gilbert's message of
	"Wed, 12 Oct 2016 09:46:27 +0100")
Message-ID: <87mvi8g3ac.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv2] monitor: deprecate 'default' option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>

"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:

> * Markus Armbruster (armbru@redhat.com) wrote:
>> Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com> writes:
>>=20
>> > This option does nothing since commit 06ac27f.  Deprecate it.
>> >
>> > Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>> > ---
>> >  vl.c                      | 11 +++--------
>> >  include/monitor/monitor.h |  2 +-
>> >  qemu-options.hx           |  8 ++++----
>> >  3 files changed, 8 insertions(+), 13 deletions(-)
>> >
>> > v2:
>> >  - update after Markus review
>> >  - fix error on default monitor
>> >  - drop from qemu-trivial
>>=20
>> Suggest to squash in the appended patch.
>>=20
>> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>>=20
>> Could go via David, Paolo or myself.  David, do you have anything
>> pending right now?
>
> I don't have anything pending at the moment; but I could
> take it; it doesn't seem especially urgent.

Please do.  Thanks!