From: Nicolai Stange <nicstange@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Nicolai Stange <nicstange@gmail.com>,
Juergen Gross <jgross@suse.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Davidlohr Bueso <dave@stgolabs.net>,
Richard Weinberger <richard@nod.at>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] smp: smp_call_on_cpu(): use INIT_WORK_ONSTACK() for automatic work_struct
Date: Thu, 22 Sep 2016 21:15:52 +0200 [thread overview]
Message-ID: <87mviz7nkn.fsf@gmail.com> (raw)
In-Reply-To: <20160922184415.GB5012@twins.programming.kicks-ass.net> (Peter Zijlstra's message of "Thu, 22 Sep 2016 20:44:15 +0200")
Peter Zijlstra <peterz@infradead.org> writes:
> On Thu, Sep 22, 2016 at 08:17:58PM +0200, Nicolai Stange wrote:
>> This new warning
>>
>> INFO: trying to register non-static key.
>> the code is fine but needs lockdep annotation.
>> turning off the locking correctness validator.
>> CPU: 0 PID: 82 Comm: kworker/0:1 Not tainted 4.8.0-rc6+ #360
>> Hardware name: Dell Inc. Latitude E6540/0725FP, BIOS A10 06/26/2014
>> Workqueue: events smp_call_on_cpu_callback
>
> https://lkml.kernel.org/r/tip-8db549491c4a3ce9e1d509b75f78516e497f48ec@git.kernel.org
Ah, thanks for letting me know.
One minor question regarding your patch though: it hasn't got a
destroy_work_on_stack(). Isn't one needed because of
INIT_WORK_ONSTACK() -> __INIT_WORK() -> __init_work() ->
debug_object_init_on_stack() ?
At least work_on_cpu() destroys its local work_struct that way...
Thanks,
Nicolai
next prev parent reply other threads:[~2016-09-22 19:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 18:17 [PATCH] smp: smp_call_on_cpu(): use INIT_WORK_ONSTACK() for automatic work_struct Nicolai Stange
2016-09-22 18:44 ` Peter Zijlstra
2016-09-22 19:15 ` Nicolai Stange [this message]
2016-09-23 7:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mviz7nkn.fsf@gmail.com \
--to=nicstange@gmail.com \
--cc=dave@stgolabs.net \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.