From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51178)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bjiI1-0006Il-RC
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 03:37:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bjiHv-00044L-TK
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 03:37:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58488)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bjiHv-00044A-NZ
	for qemu-devel@nongnu.org; Tue, 13 Sep 2016 03:37:51 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 32EA761E76
	for <qemu-devel@nongnu.org>; Tue, 13 Sep 2016 07:37:51 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <20160912091913.15831-1-marcandre.lureau@redhat.com>
	<20160912091913.15831-19-marcandre.lureau@redhat.com>
	<0211fca4-22a5-2c6f-ded5-377bb41f2aba@redhat.com>
Date: Tue, 13 Sep 2016 09:37:48 +0200
In-Reply-To: <0211fca4-22a5-2c6f-ded5-377bb41f2aba@redhat.com> (Eric Blake's
	message of "Mon, 12 Sep 2016 16:22:04 -0500")
Message-ID: <87mvjcgshf.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by
 docs/qmp-commands.txt
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org

Eric Blake <eblake@redhat.com> writes:

> On 09/12/2016 04:19 AM, Marc-Andr=C3=A9 Lureau wrote:
>> The only remaining function of qmp-commands.hx is to let us generate
>> qmp-commands.txt from it.  Replace qmp-commands.hx by qmp-commands.txt.
>>=20
>> We intend to move the documentation into the QAPI schema and generate
>> qapi-commands.txt from it, but not right now.
>>=20
>> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>> ---
>>  Makefile                                 |    6 +-
>>  .gitignore                               |    1 -
>>  MAINTAINERS                              |    1 -
>>  docs/qapi-code-gen.txt                   |    6 +-
>>  qmp-commands.hx =3D> docs/qmp-commands.txt | 1127 ---------------------=
---------
>>  docs/writing-qmp-commands.txt            |   38 -
>>  6 files changed, 4 insertions(+), 1175 deletions(-)
>>  rename qmp-commands.hx =3D> docs/qmp-commands.txt (87%)
>>=20
>
>> +++ b/MAINTAINERS
>> @@ -1237,7 +1237,6 @@ M: Markus Armbruster <armbru@redhat.com>
>>  S: Supported
>>  F: qmp.c
>>  F: monitor.c
>> -F: qmp-commands.hx
>>  F: docs/*qmp-*
>>  F: scripts/qmp/
>>  T: git git://repo.or.cz/qemu/armbru.git qapi-next
>
> Shouldn't we be adding F: qmp-commands.txt somewhere to the file in the
> interim, at least until the promised later patch lands that once again
> generates documentation (this time from .json files)?

It's covered by the existing F: docs/*qmp-* line.