From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile Date: Tue, 13 Sep 2016 12:34:08 +0300 Message-ID: <87mvjcta7j.fsf@intel.com> References: <1473602239-15855-1-git-send-email-adrienverge@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1473602239-15855-1-git-send-email-adrienverge@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Adrien =?utf-8?Q?Verg=C3=A9?= List-Id: dri-devel@lists.freedesktop.org On Sun, 11 Sep 2016, Adrien Vergé wrote: > On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166), > the screen is tiled in many 480×320 screens (like a mosaic) since v4.7. > This laptop is simply unusable. > > I have bisected the cause to commit a05628195a0d ("drm/i915: Get > panel_type from OpRegion panel details"). > > Like for Skylake, it seems that using the OpRegion panel type (here, 0) > causes the problem, whereas the VBT panel type (here, 7) gives a normal > display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from > OpRegion on SKL") for background on this Skylake fix. > > This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips. Please try this patch [1] instead, and reply to it if it works for you. BR, Jani. [1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com > > Tested-by: Adrien Vergé > Signed-off-by: Adrien Vergé > --- > drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > index adca262..94e2db7 100644 > --- a/drivers/gpu/drm/i915/intel_opregion.c > +++ b/drivers/gpu/drm/i915/intel_opregion.c > @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > return -ENODEV; > } > > + /* > + * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the > + * OpRegion panel type (0) results in tiled ("mosaic") display bug, > + * whereas the VBT panel type (7) gives a normal display. > + * Let's ignore the OpRegion panel type for this chip. > + */ > + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) { > + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); > + return -ENODEV; > + } > + > return ret - 1; > } -- Jani Nikula, Intel Open Source Technology Center From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932404AbcIMJeN convert rfc822-to-8bit (ORCPT ); Tue, 13 Sep 2016 05:34:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:20585 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932282AbcIMJeM (ORCPT ); Tue, 13 Sep 2016 05:34:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,328,1470726000"; d="scan'208";a="1055248614" From: Jani Nikula To: Adrien =?utf-8?Q?Verg=C3=A9?= , Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , David Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Adrien =?utf-8?Q?Verg=C3=A9?= Subject: Re: [PATCH] drm/i915: Ignore OpRegion panel type on Ivy Bridge + Mobile In-Reply-To: <1473602239-15855-1-git-send-email-adrienverge@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1473602239-15855-1-git-send-email-adrienverge@gmail.com> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 13 Sep 2016 12:34:08 +0300 Message-ID: <87mvjcta7j.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 11 Sep 2016, Adrien Vergé wrote: > On Terra Mobile Ultrabook 1450 II (Core i5-3337U, i915 devid = 0x166), > the screen is tiled in many 480×320 screens (like a mosaic) since v4.7. > This laptop is simply unusable. > > I have bisected the cause to commit a05628195a0d ("drm/i915: Get > panel_type from OpRegion panel details"). > > Like for Skylake, it seems that using the OpRegion panel type (here, 0) > causes the problem, whereas the VBT panel type (here, 7) gives a normal > display. See commit aeddda06c1a7 ("drm/i915: Ignore panel type from > OpRegion on SKL") for background on this Skylake fix. > > This patch ignores OpRegion panel type for Ivy Bridge + Mobile chips. Please try this patch [1] instead, and reply to it if it works for you. BR, Jani. [1] http://patchwork.freedesktop.org/patch/msgid/1473758539-21565-1-git-send-email-ville.syrjala@linux.intel.com > > Tested-by: Adrien Vergé > Signed-off-by: Adrien Vergé > --- > drivers/gpu/drm/i915/intel_opregion.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c > index adca262..94e2db7 100644 > --- a/drivers/gpu/drm/i915/intel_opregion.c > +++ b/drivers/gpu/drm/i915/intel_opregion.c > @@ -1083,5 +1083,16 @@ intel_opregion_get_panel_type(struct drm_i915_private *dev_priv) > return -ENODEV; > } > > + /* > + * FIXME On Terra Mobile Ultrabook 1450 II (Intel Core i5-3337U) the > + * OpRegion panel type (0) results in tiled ("mosaic") display bug, > + * whereas the VBT panel type (7) gives a normal display. > + * Let's ignore the OpRegion panel type for this chip. > + */ > + if (IS_IVYBRIDGE(dev_priv) && IS_MOBILE(dev_priv)) { > + DRM_DEBUG_KMS("Ignoring OpRegion panel type (%d)\n", ret - 1); > + return -ENODEV; > + } > + > return ret - 1; > } -- Jani Nikula, Intel Open Source Technology Center