From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH -next] drm/i915: Fix non static symbol warning Date: Mon, 22 Aug 2016 16:03:07 +0300 Message-ID: <87mvk5t0qc.fsf@intel.com> References: <1471792798-16709-1-git-send-email-weiyj.lk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1471792798-16709-1-git-send-email-weiyj.lk@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Wei Yongjun , Daniel Vetter , David Airlie Cc: intel-gfx@lists.freedesktop.org, Wei Yongjun , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCAyMSBBdWcgMjAxNiwgV2VpIFlvbmdqdW4gPHdlaXlqLmxrQGdtYWlsLmNvbT4gd3Jv dGU6Cj4gRnJvbTogV2VpIFlvbmdqdW4gPHdlaXlvbmdqdW4xQGh1YXdlaS5jb20+Cj4KPiBGaXhl cyB0aGUgZm9sbG93aW5nIHNwYXJzZSB3YXJuaW5nOgo+Cj4gZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfaG90cGx1Zy5jOjQ4MDo2OiB3YXJuaW5nOgo+ICBzeW1ib2wgJ2k5MTVfaHBkX3BvbGxf aW5pdF93b3JrJyB3YXMgbm90IGRlY2xhcmVkLiBTaG91bGQgaXQgYmUgc3RhdGljPwo+Cj4gQWxz byBtb3ZlIHRoZSAneycgdG8gbmV3IGxpbmUuCgpUaGFua3MgZm9yIHRoZSBwYXRjaCwgYnV0IHdl J3ZlIGFscmVhZHkgZml4ZWQgdGhpcyBpbgoKY29tbWl0IDI0ODA4ZTk2NzkyYTg2MGYzZTgzZTJl YjY5YzUxOTAyNjE3MTY5MjQKQXV0aG9yOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNv bi5jby51az4KRGF0ZTogICBXZWQgQXVnIDE3IDEyOjA5OjA2IDIwMTYgKzAxMDAKCiAgICBkcm0v aTkxNTogTWFyayBpOTE1X2hwZF9wb2xsX2luaXRfd29yayBhcyBzdGF0aWMKCkJSLApKYW5pLgoK Pgo+IFNpZ25lZC1vZmYtYnk6IFdlaSBZb25nanVuIDx3ZWl5b25nanVuMUBodWF3ZWkuY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ob3RwbHVnLmMgfCAzICsrLQo+ICAx IGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4KPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gaW5kZXggNWRjMmMyMC4uMzM0ZDQ3YiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ob3RwbHVnLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ob3RwbHVnLmMKPiBAQCAtNDc3LDcgKzQ3Nyw4IEBAIHZv aWQgaW50ZWxfaHBkX2luaXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ICAJ c3Bpbl91bmxvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ICB9Cj4gIAo+IC12b2lkIGk5 MTVfaHBkX3BvbGxfaW5pdF93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykgewo+ICtzdGF0 aWMgdm9pZCBpOTE1X2hwZF9wb2xsX2luaXRfd29yayhzdHJ1Y3Qgd29ya19zdHJ1Y3QgKndvcmsp Cj4gK3sKPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9Cj4gIAkJY29udGFp bmVyX29mKHdvcmssIHN0cnVjdCBkcm1faTkxNV9wcml2YXRlLAo+ICAJCQkgICAgIGhvdHBsdWcu cG9sbF9pbml0X3dvcmspOwo+CgotLSAKSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRl Y2hub2xvZ3kgQ2VudGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755449AbcHVNDZ (ORCPT ); Mon, 22 Aug 2016 09:03:25 -0400 Received: from mga05.intel.com ([192.55.52.43]:51657 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752876AbcHVNDY (ORCPT ); Mon, 22 Aug 2016 09:03:24 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,560,1464678000"; d="scan'208";a="1045330111" From: Jani Nikula To: Wei Yongjun , Daniel Vetter , David Airlie Cc: Wei Yongjun , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] drm/i915: Fix non static symbol warning In-Reply-To: <1471792798-16709-1-git-send-email-weiyj.lk@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1471792798-16709-1-git-send-email-weiyj.lk@gmail.com> User-Agent: Notmuch/0.22.1+63~g648dcc7 (https://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Mon, 22 Aug 2016 16:03:07 +0300 Message-ID: <87mvk5t0qc.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Aug 2016, Wei Yongjun wrote: > From: Wei Yongjun > > Fixes the following sparse warning: > > drivers/gpu/drm/i915/intel_hotplug.c:480:6: warning: > symbol 'i915_hpd_poll_init_work' was not declared. Should it be static? > > Also move the '{' to new line. Thanks for the patch, but we've already fixed this in commit 24808e96792a860f3e83e2eb69c5190261716924 Author: Chris Wilson Date: Wed Aug 17 12:09:06 2016 +0100 drm/i915: Mark i915_hpd_poll_init_work as static BR, Jani. > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/drm/i915/intel_hotplug.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c > index 5dc2c20..334d47b 100644 > --- a/drivers/gpu/drm/i915/intel_hotplug.c > +++ b/drivers/gpu/drm/i915/intel_hotplug.c > @@ -477,7 +477,8 @@ void intel_hpd_init(struct drm_i915_private *dev_priv) > spin_unlock_irq(&dev_priv->irq_lock); > } > > -void i915_hpd_poll_init_work(struct work_struct *work) { > +static void i915_hpd_poll_init_work(struct work_struct *work) > +{ > struct drm_i915_private *dev_priv = > container_of(work, struct drm_i915_private, > hotplug.poll_init_work); > -- Jani Nikula, Intel Open Source Technology Center