From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51331)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bXOFb-0003vG-SJ
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:48:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bXOFX-0003rs-Lh
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:48:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44134)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bXOFX-0003rX-Ga
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 03:48:27 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 175B9C04B317
	for <qemu-devel@nongnu.org>; Wed, 10 Aug 2016 07:48:27 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <1470757664-25161-1-git-send-email-pbonzini@redhat.com>
	<1470757664-25161-3-git-send-email-pbonzini@redhat.com>
	<874m6t5d39.fsf@dusky.pond.sub.org>
	<1550519450.770774.1470812913274.JavaMail.zimbra@redhat.com>
Date: Wed, 10 Aug 2016 09:48:24 +0200
In-Reply-To: <1550519450.770774.1470812913274.JavaMail.zimbra@redhat.com>
	(Paolo Bonzini's message of "Wed, 10 Aug 2016 03:08:33 -0400 (EDT)")
Message-ID: <87mvkl2hfb.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/3] checkpatch: bump most warnings to
 errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: thuth@redhat.com, famz@redhat.com, qemu-devel@nongnu.org

Paolo Bonzini <pbonzini@redhat.com> writes:

>> Paolo Bonzini <pbonzini@redhat.com> writes:
>> 
>> > This only leaves a warning-level message for extra-long lines, which
>> > are relatively common and cause patchew to send email that will likely
>> > be ignored.
>> >
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> 
>> Are we ready to give up on illegibly long lines?
>
> We have other levels of code review than checkpatch.  80 chars can be
> illegibly short in some circumstances where 83 or 84 are enough.

Isn't that addressed neatly in your patch?  It has a soft and a hard
limit.  Exceeding the hard limit is an error, exceeding the soft limit
is a warning.  I rather liked that.  If I remember correctly, the only
disagreements were about the value of the soft limit.

> Paolo
>
>> What happened to "[PATCH 2/4] CODING_STYLE, checkpatch: update line
>> length rules"?