From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47268) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWh85-0005T8-Pw for qemu-devel@nongnu.org; Mon, 08 Aug 2016 05:45:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bWh82-0007PV-Mi for qemu-devel@nongnu.org; Mon, 08 Aug 2016 05:45:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51036) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bWh82-0007PK-Fz for qemu-devel@nongnu.org; Mon, 08 Aug 2016 05:45:50 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0156C61E44 for ; Mon, 8 Aug 2016 09:45:50 +0000 (UTC) From: Markus Armbruster References: <20160801112343.29082-1-marcandre.lureau@redhat.com> <20160801112343.29082-3-marcandre.lureau@redhat.com> <3f8460f7-d364-78e1-dc52-0a3cf8141f18@redhat.com> Date: Mon, 08 Aug 2016 11:45:47 +0200 In-Reply-To: <3f8460f7-d364-78e1-dc52-0a3cf8141f18@redhat.com> (Paolo Bonzini's message of "Mon, 1 Aug 2016 13:32:07 +0200") Message-ID: <87mvknh9v8.fsf@dusky.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.7 2/2] audio: clean up before monitor clean up List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, Gerd Hoffmann Paolo Bonzini writes: > On 01/08/2016 13:23, marcandre.lureau@redhat.com wrote: >> From: Marc-Andr=C3=A9 Lureau >>=20 >> Since aa5cb7f5e, the chardevs are being cleaned up when leaving qemu, >> before the atexit() handlers. audio_cleanup() may use the monitor to >> notify of changes. For compatibility reasons, let's clean up audio >> before the monitor so it keeps emitting monitor events. >>=20 >> The audio_atexit() function is made idempotent (so it can be called >> multiple times), > > That's a very good idea, as it avoids having to establish exit notifiers > as we did for net/. > > Reviewed-by: Paolo Bonzini Does the R-by apply to PATCH 1/2 as well? > The two patches conflict with each other, so it's probably easiest if > one of Gerd or Markus takes both. I can squeeze in review and a pull request today. Gerd, if you'd prefer to do it yourself, let me know.