From: "Bjørn Mork" <bjorn@mork.no>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Oliver Neukum <oneukum@suse.de>,
linux-usb@vger.kernel.org, <stable@vger.kernel.org>
Subject: Re: [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications
Date: Fri, 13 May 2016 18:59:25 +0200 [thread overview]
Message-ID: <87mvntevwy.fsf@nemi.mork.no> (raw)
In-Reply-To: <1463153977-19771-1-git-send-email-bjorn@mork.no> ("Bjørn Mork"'s message of "Fri, 13 May 2016 17:39:37 +0200")
Bjørn Mork <bjorn@mork.no> writes:
> The driver enforces a strict one-to-one relationship between the
> received RESPONSE_AVAILABLE notifications and messages read from
> the device. At the same time, it will cancel the interrupt URB
> when there is no client holding the character device open.
Never mind. Forget it.
This patch breaks other devices again. The immediate and unconditional
reading make them barf. I guess it can be worked around by delaying the
flushing until at least one notification is received, but I obviously
have to test this theory thoroughly on all devices I have.
Bjørn
next prev parent reply other threads:[~2016-05-13 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 15:39 [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications Bjørn Mork
2016-05-13 16:59 ` Bjørn Mork [this message]
2016-05-17 9:13 ` Oliver Neukum
2016-05-17 19:24 ` Bjørn Mork
2016-05-17 21:49 ` Oliver Neukum
2016-05-17 23:39 ` Bjørn Mork
2016-05-18 8:12 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvntevwy.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.