From: Hitoshi Mitake <mitake.hitoshi@gmail.com>
To: Kazuki Yamaguchi <k@rhe.jp>
Cc: git@vger.kernel.org, Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>
Subject: Re: [PATCH 0/2] imap-send: fixes for CRAM-MD5 authentication
Date: Sat, 09 Apr 2016 15:29:30 +0900 [thread overview]
Message-ID: <87mvp35m7p.wl%mitake.hitoshi@gmail.com> (raw)
In-Reply-To: <20160408140218.GA13469@chikuwa.rhe.jp>
At Fri, 8 Apr 2016 23:02:18 +0900,
Kazuki Yamaguchi wrote:
>
> [1/2]
> Check for LOGINDISABLED capability only when using LOGIN command, as it
> is unrelated to authentication with CRAM-MD5.
>
> [2/2]
> Remove extra + 1, which is probably mistakenly added. Without this patch
> I can't open my IMAP server (Dovecot 2.2).
>
> Thanks,
>
> Kazuki Yamaguchi (2):
> imap-send: check for NOLOGIN capability only when using LOGIN command
> imap-send: fix CRAM-MD5 response calculation
>
> imap-send.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Yamaguchi-san, thanks for your patches and letting me know. The
CRAM-MD5 feature would have problems as you pointed. I just
implemented it for my own usecase years ago (at that time I used
Cyrus) and am not using it for now. The code is old but not tested
well yet (I'm not sure how many people are using it).
Unfortunately I can't test the patches because I don't have an IMAP
server that is suitable for testing. But I think the patches are worth
to apply because they are valuable for your usecase. Sorry for my
irresponible answer :(
prev parent reply other threads:[~2016-04-09 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 14:02 [PATCH 0/2] imap-send: fixes for CRAM-MD5 authentication Kazuki Yamaguchi
2016-04-09 6:29 ` Hitoshi Mitake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvp35m7p.wl%mitake.hitoshi@gmail.com \
--to=mitake.hitoshi@gmail.com \
--cc=git@vger.kernel.org \
--cc=k@rhe.jp \
--cc=mitake@dcl.info.waseda.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.