From: Felipe Balbi <balbi@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: gadget: f_midi: unlock on error
Date: Mon, 04 Apr 2016 12:18:06 +0000 [thread overview]
Message-ID: <87mvp96001.fsf@intel.com> (raw)
In-Reply-To: <20160402045108.GD11775@mwanda>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
Michal Nazarewicz <mina86@mina86.com> writes:
> On Sat, Apr 02 2016, Dan Carpenter wrote:
>> We added some new locking here, but missed an error path where we need
>> to unlock.
>>
>> Fixes: 9acdf4df2fc4 ('usb: gadget: f_midi: added spinlock on transmit function')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>
> Acked-by: Michal Nazarewicz <mina86@mina86.com>
>
> But perhaps this would be cleaner:
both options below are not real fixes and, as such, as not subject to
the -rc cycle.
thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2016-04-04 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-02 4:51 [patch] usb: gadget: f_midi: unlock on error Dan Carpenter
2016-04-04 9:43 ` Felipe Ferreri Tonello
2016-04-04 12:11 ` Michal Nazarewicz
2016-04-04 12:18 ` Felipe Balbi [this message]
2016-04-04 13:22 ` Felipe Ferreri Tonello
2016-04-04 19:25 ` Michal Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvp96001.fsf@intel.com \
--to=balbi@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.