Re: [PATCH 1/5 v10] dt/bindings: Add binding for the DA8xx MUSB driver

[Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]


Hi,

David Lechner <david-nq/r/kbU++upp/zk7JDF2g@public.gmane.org> writes:
> [ text/plain ]
> On 03/14/2016 02:00 AM, Felipe Balbi wrote:
>>
>> Hi,
>>
>> Petr Kulhavy <petr-Qh/3xLP0EvwAvxtiuMwx3w@public.gmane.org> writes:
>>> + - ti,usb2-phy-refclock-hz : Integer. Frequency in Hz of the USB 2.0 PHY reference clock,
>>> +     either provided by the internal PLL or an external source.
>>> +     The supported values are: 12MHz, 13MHz, 19.2MHz, 20MHz, 24MHz, 26MHz, 38.4MHz, 40MHz, 48MHz.
>>
>> why isn't this an actual clock phandle ? Driver could, then, use
>> clk_get_rate() to figure this one out. You could just use a fixed clock
>> here to satisfy the clock API.
>>
>
>
> I've actually been working on getting the da8xx ohci driver working with 
> device tree. It has similar clock issues (in fact, the ohci clock is a 
> child of the musb clock). Petr, give me a day or two and will have post 
> some patches. It will have a clock that can be used here for clk_get_rate().

sounds good, cool.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]