From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() Date: Tue, 09 Feb 2016 22:27:48 +0200 Message-ID: <87mvr9vdbv.fsf@intel.com> References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-3-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1455048677-19882-3-git-send-email-linux@rasmusvillemoes.dk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , David Airlie Cc: intel-gfx@lists.freedesktop.org, Rasmus Villemoes , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCAwOSBGZWIgMjAxNiwgUmFzbXVzIFZpbGxlbW9lcyA8bGludXhAcmFzbXVzdmlsbGVt b2VzLmRrPiB3cm90ZToKPiBUaGlzIGZhaWxzIHRvIHVuZG8gdGhlIHNldHVwIGZvciBwaW49PTA7 IG1vcmVvdmVyLCBzb21ldGhpbmcKPiBpbnRlcmVzdGluZyBoYXBwZW5zIGlmIHRoZSBzZXR1cCBm YWlsZWQgYWxyZWFkeSBhdCBwaW49PTAuCj4KPiBTaWduZWQtb2ZmLWJ5OiBSYXNtdXMgVmlsbGVt b2VzIDxsaW51eEByYXNtdXN2aWxsZW1vZXMuZGs+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2kyYy5jIHwgMiArLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyks IDEgZGVsZXRpb24oLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9pMmMuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2kyYy5jCj4gaW5kZXggMjUyNTRi NWMxYWM1Li5kZWI4MjgyYzI2ZDggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfaTJjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9pMmMuYwo+IEBA IC02ODMsNyArNjgzLDcgQEAgaW50IGludGVsX3NldHVwX2dtYnVzKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpCj4gIAlyZXR1cm4gMDsKPiAgCj4gIGVycjoKPiAtCXdoaWxlICgtLXBpbikgewo+ICsJ d2hpbGUgKHBpbi0tKSB7Cj4gIAkJaWYgKCFpbnRlbF9nbWJ1c19pc192YWxpZF9waW4oZGV2X3By aXYsIHBpbikpCj4gIAkJCWNvbnRpbnVlOwoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5p Lm5pa3VsYUBpbnRlbC5jb20+CkZpeGVzOiBmODk5ZmM2NGNkYTggKCJkcm0vaTkxNTogdXNlIEdN QlVTIHRvIG1hbmFnZSBpMmMgbGlua3MiKQpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwoKCi0t IApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755394AbcBIU2D (ORCPT ); Tue, 9 Feb 2016 15:28:03 -0500 Received: from mga14.intel.com ([192.55.52.115]:44171 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbcBIU2B (ORCPT ); Tue, 9 Feb 2016 15:28:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,422,1449561600"; d="scan'208";a="911840530" From: Jani Nikula To: Rasmus Villemoes , Daniel Vetter , David Airlie Cc: Rasmus Villemoes , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] drm/i915: fix error path in intel_setup_gmbus() In-Reply-To: <1455048677-19882-3-git-send-email-linux@rasmusvillemoes.dk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1455048677-19882-1-git-send-email-linux@rasmusvillemoes.dk> <1455048677-19882-3-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Notmuch/0.21+33~g570c0ae (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 09 Feb 2016 22:27:48 +0200 Message-ID: <87mvr9vdbv.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Feb 2016, Rasmus Villemoes wrote: > This fails to undo the setup for pin==0; moreover, something > interesting happens if the setup failed already at pin==0. > > Signed-off-by: Rasmus Villemoes > --- > drivers/gpu/drm/i915/intel_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_i2c.c b/drivers/gpu/drm/i915/intel_i2c.c > index 25254b5c1ac5..deb8282c26d8 100644 > --- a/drivers/gpu/drm/i915/intel_i2c.c > +++ b/drivers/gpu/drm/i915/intel_i2c.c > @@ -683,7 +683,7 @@ int intel_setup_gmbus(struct drm_device *dev) > return 0; > > err: > - while (--pin) { > + while (pin--) { > if (!intel_gmbus_is_valid_pin(dev_priv, pin)) > continue; Reviewed-by: Jani Nikula Fixes: f899fc64cda8 ("drm/i915: use GMBUS to manage i2c links") Cc: stable@vger.kernel.org -- Jani Nikula, Intel Open Source Technology Center