From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>
To: "Herrero,
Gregory"
<gregory.herrero-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
Zhangfei Gao
<zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH] usb: dwc2: add support of hi6220
Date: Fri, 20 Nov 2015 11:20:52 -0600 [thread overview]
Message-ID: <87mvu8d1u3.fsf@saruman.tx.rr.com> (raw)
In-Reply-To: <20151120161533.GA2987@herrerog>
[-- Attachment #1: Type: text/plain, Size: 1031 bytes --]
"Herrero, Gregory" <gregory.herrero-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> writes:
> Hi Felipe,
>
> I just realized this patch miss "dma_desc_fs_enable" property in
> params_hi6220. (drivers/usb/dwc2/platform.c:57)
>
> You need to apply this patch:
>
> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
> index d5102c4..2dfdae3 100644
> --- a/drivers/usb/dwc2/platform.c
> +++ b/drivers/usb/dwc2/platform.c
> @@ -59,6 +59,7 @@ static const struct dwc2_core_params params_hi6220 = {
> .otg_ver = 0, /* 1.3 */
> .dma_enable = 1,
> .dma_desc_enable = 0,
> + .dma_desc_fs_enable = 0,
> .speed = 0, /* High Speed */
> .enable_dynamic_fifo = 1,
> .en_multiple_tx_fifo = 1,
>
>
> Note that it is needed due to below patch.
> "usb: dwc2: host: enable descriptor dma for fs devices"
done, thanks.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
next prev parent reply other threads:[~2015-11-20 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-18 7:39 [PATCH] usb: dwc2: add support of hi6220 Zhangfei Gao
2015-11-19 2:36 ` John Youn
[not found] ` <1447832387-27549-1-git-send-email-zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2015-11-18 23:03 ` Rob Herring
2015-11-19 19:04 ` Felipe Balbi
2015-11-20 4:58 ` John Youn
[not found] ` <2B3535C5ECE8B5419E3ECBE30077290901DC3D9462-Yu2iAY70zvrYN67daEjeMPufCSb+aD3WLzEdoUbNIic@public.gmane.org>
2015-11-20 15:34 ` Felipe Balbi
[not found] ` <871tbkelca.fsf-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org>
2015-11-20 16:15 ` Herrero, Gregory
2015-11-20 17:20 ` Felipe Balbi [this message]
2015-11-23 3:51 ` zhangfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvu8d1u3.fsf@saruman.tx.rr.com \
--to=balbi-l0cymroini0@public.gmane.org \
--cc=John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gregory.herrero-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=zhangfei.gao-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.