Re: [PATCH 1/2] drm/i915: Make sure we don't detect eDP on g4x

[Jani Nikula <jani.nikula@linux.intel.com>]

On Fri, 11 Sep 2015, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> We don't support eDP on g4x, so let's not even look at the VBT
> to determine the port type, just in case the VBT is bonkers
> on some g4x machines and indicates the precense of eDP.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/intel_dp.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 292c753..eb37335 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5250,6 +5250,13 @@ bool intel_dp_is_edp(struct drm_device *dev, enum port port)
>  		[PORT_E] = DVO_PORT_DPE,
>  	};
>  
> +	/*
> +	 * eDP not supported on g4x. so bail out early just
> +	 * for a bit extra safety in case the VBT is bonkers.
> +	 */
> +	if (INTEL_INFO(dev)->gen < 5)
> +		return false;
> +
>  	if (port == PORT_A)
>  		return true;
>  
> -- 
> 2.4.6
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx