From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vitaly Kuznetsov <vkuznets@redhat.com>
Subject: Re: [PATCH v9 06/11] xen: Introduce
	XEN_DOMCTL_soft_reset
Date: Fri, 17 Jul 2015 14:30:12 +0200
Message-ID: <87mvyvnezv.fsf@vitty.brq.redhat.com>
References: <1437064046-12174-1-git-send-email-vkuznets@redhat.com>
	<1437064046-12174-7-git-send-email-vkuznets@redhat.com>
	<20150716184507.GH14309@x230.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <vkuznets@redhat.com>) id 1ZG4sG-0001bF-Ja
	for xen-devel@lists.xenproject.org; Fri, 17 Jul 2015 12:36:20 +0000
In-Reply-To: <20150716184507.GH14309@x230.dumpdata.com> (Konrad Rzeszutek
	Wilk's message of "Thu, 16 Jul 2015 14:45:07 -0400")
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Andrew Jones <drjones@redhat.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien.grall@linaro.org>, Ian Jackson <ian.jackson@eu.citrix.com>, Olaf Hering <olaf@aepfle.de>, Tim Deegan <tim@xen.org>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, Daniel De Graaf <dgdegra@tycho.nsa.gov>
List-Id: xen-devel@lists.xenproject.org

Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> writes:

>>  
>> @@ -1010,6 +1017,29 @@ int domain_unpause_by_systemcontroller(struct domain *d)
>>      return 0;
>>  }
>>  
>> +int domain_soft_reset(struct domain *d)
>> +{
>> +    struct vcpu *v;
>> +    int rc;
>> +
>> +    spin_lock(&d->shutdown_lock);
>> +    for_each_vcpu ( d, v )
>> +        if ( !v->paused_for_shutdown )
>> +            return -EINVAL;
>
> Ahem. You leave the spinlock still locked :-(
>

Ouch... :-(

-- 
  Vitaly