From: Markus Armbruster <armbru@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
qemu-devel@nongnu.org, Don Slutz <dslutz@verizon.com>,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration
Date: Tue, 25 Nov 2014 12:11:36 +0100 [thread overview]
Message-ID: <87mw7flel3.fsf@blackfin.pond.sub.org> (raw)
In-Reply-To: <20141125085915.GA2550@work-vm> (David Alan Gilbert's message of "Tue, 25 Nov 2014 08:59:15 +0000")
"Dr. David Alan Gilbert" <dgilbert@redhat.com> writes:
> * Don Slutz (dslutz@verizon.com) wrote:
>> On 11/21/14 05:49, Dr. David Alan Gilbert wrote:
>> >* Markus Armbruster (armbru@redhat.com) wrote:
[...]
>> >>Management tools should use -nodefaults. But if it mixes default and
>> >>-nodefaults in migration, recreating the stuff it got by default but
>> >>doesn't get with -nodefaults is its own responsibility.
>>
>> Yes. Since xen did not ask for a CD-ROM, it did not expect to need to create
>> it. xen was "fixed" to use -nodefaults.
>>
>> >Well, mostly - we wouldn't expect a migration to work if the source/dest
>> >didn't match exactly; but QEMU shouldn't seg.
>>
>> Well, this change prevents a seg. So you are in favor of having this
>> backported?
>
> Yes.
I gladly defer to Dave's judgement here.
prev parent reply other threads:[~2014-11-25 11:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 21:20 [Qemu-devel] [BUGFIX][PATCH for 2.2 1/1] hw/ide/core.c: Prevent SIGSEGV during migration Don Slutz
2014-11-18 10:05 ` Paolo Bonzini
2014-11-18 11:37 ` Stefan Hajnoczi
2014-11-18 11:41 ` Kevin Wolf
2014-11-18 18:00 ` Peter Maydell
2014-11-18 14:12 ` Stefano Stabellini
2014-11-18 14:12 ` Stefano Stabellini
2014-11-19 10:52 ` Stefano Stabellini
2014-11-19 11:08 ` Konrad Rzeszutek Wilk
2014-11-19 12:00 ` Stefano Stabellini
2014-11-19 12:29 ` [Qemu-devel] " Markus Armbruster
2014-11-20 18:31 ` Don Slutz
2014-11-21 8:42 ` Markus Armbruster
2014-11-21 10:49 ` Dr. David Alan Gilbert
2014-11-25 0:48 ` Don Slutz
2014-11-25 8:59 ` Dr. David Alan Gilbert
2014-11-25 11:11 ` Markus Armbruster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mw7flel3.fsf@blackfin.pond.sub.org \
--to=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dslutz@verizon.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.