From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaime Velasco Juan Subject: Re: [PATCH] input: atkbd - Fix broken keyboard in another LG laptop Date: Thu, 11 Sep 2014 17:53:08 +0100 Message-ID: <87mwa6xfnv.fsf@gmail.com> References: <1410372374-11591-1-git-send-email-jsagarribay@gmail.com> <20140910205213.GD38736@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from mail-wi0-f179.google.com ([209.85.212.179]:38000 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757176AbaIKQxX (ORCPT ); Thu, 11 Sep 2014 12:53:23 -0400 In-Reply-To: <20140910205213.GD38736@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, stable@vger.kernel.org, Sheng-Liang Song Dmitry Torokhov writes: > Hi Jamie, > > On Wed, Sep 10, 2014 at 07:06:14PM +0100, Jaime Velasco Juan wrote: >> This model has the same quirk as others, see 3d725caa9dcc "Input: >> atkbd - fix keyboard not working on some LG laptops" >> > > How about the patch below instead? > It works for me just the same, thanks. Regards > -- > Dmitry > > Input: atkbd - do not try 'deactivate' keyboard on any LG laptops > > From: Dmitry Torokhov > > We are getting more and more reports about LG laptops not having > functioning keyboard if we try to deactivate keyboard during probe. > Given that having keyboard deactivated is merely "nice to have" > instead of a hard requirement for probing, let's disable it on all > LG boxes instead of trying to hunt down particular models. > > This change is prompted by patches trying to add "LG Electronics"/"ROCKY" > and "LG Electronics"/"LW60-F27B" to the DMI list. > > https://bugzilla.kernel.org/show_bug.cgi?id=77051 > > Cc: stable@vger.kernel.org > Reported-by: Jaime Velasco Juan > Reported-by: Georgios Tsalikis > Signed-off-by: Dmitry Torokhov > --- > drivers/input/keyboard/atkbd.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c > index 2dd1d0d..6f5d795 100644 > --- a/drivers/input/keyboard/atkbd.c > +++ b/drivers/input/keyboard/atkbd.c > @@ -1791,14 +1791,6 @@ static const struct dmi_system_id atkbd_dmi_quirk_table[] __initconst = { > { > .matches = { > DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"), > - DMI_MATCH(DMI_PRODUCT_NAME, "LW25-B7HV"), > - }, > - .callback = atkbd_deactivate_fixup, > - }, > - { > - .matches = { > - DMI_MATCH(DMI_SYS_VENDOR, "LG Electronics"), > - DMI_MATCH(DMI_PRODUCT_NAME, "P1-J273B"), > }, > .callback = atkbd_deactivate_fixup, > },