From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbaHKIRl (ORCPT ); Mon, 11 Aug 2014 04:17:41 -0400 Received: from LGEMRELSE6Q.lge.com ([156.147.1.121]:33583 "EHLO lgemrelse6q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331AbaHKIRj (ORCPT ); Mon, 11 Aug 2014 04:17:39 -0400 X-Original-SENDERIP: 10.177.220.181 X-Original-MAILFROM: namhyung@gmail.com From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Paul Mackerras , Namhyung Kim , LKML , Jiri Olsa Subject: Re: [PATCH 8/8] perf symbol: Don't demangle parameters and such by default References: <1406785662-5534-1-git-send-email-namhyung@kernel.org> <1406785662-5534-9-git-send-email-namhyung@kernel.org> <20140802133503.GE13375@kernel.org> Date: Mon, 11 Aug 2014 17:17:37 +0900 In-Reply-To: <20140802133503.GE13375@kernel.org> (Arnaldo Carvalho de Melo's message of "Sat, 2 Aug 2014 10:35:03 -0300") Message-ID: <87mwbbfnj2.fsf@sejong.aot.lge.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2 Aug 2014 10:35:03 -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jul 31, 2014 at 02:47:42PM +0900, Namhyung Kim escreveu: >> Some C++ symbols have very long name and they make column length >> longer. Most of them are about parameters including templates and we >> can ignore such info most of time IMHO. >> >> This patch passes DMGL_NO_OPTS by default when calling bfd_demangle(). >> One can still see full symbols with -v/--verbose option. >> >> before: >> JS_CallFunctionValue(JSContext*, JSObject*, JS::Value, unsigned int, JS::Value*, JS::Value*) >> >> after: >> JS_CallFunctionValue > > Are you sure we want that? > > With this we'll end up having different instantiations having the same > name, since the way to differentiate them is exactly by a different > parameter list, no? Right, but I think it's not a big problem since such overloaded functions will not be shown at the same time as only one of them might do the real work most cases. Simply noticing one of them is a performance bottle neck would be helpful to the developer, I guess. Even if it's not the case, one still can see and identify the correct one using the -v option. For me, it's just annoying when (unimportant) C++ symbols occupy too much space in a limited terminal width. Thanks, Namhyung