From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wuzxd-0001X9-Pg for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:02:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WuzxV-0008DB-9d for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:02:13 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:56195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WuzxU-0008Bs-BE for qemu-devel@nongnu.org; Thu, 12 Jun 2014 04:02:05 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 Jun 2014 13:32:00 +0530 From: Nikunj A Dadhania In-Reply-To: <5398127D.9020506@ozlabs.ru> References: <1402387005-28901-3-git-send-email-nikunj@linux.vnet.ibm.com> <5398127D.9020506@ozlabs.ru> Date: Thu, 12 Jun 2014 13:31:55 +0530 Message-ID: <87mwdifte4.fsf@abhimanyu.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] ppc: spapr-rtas - implement os-term rtas call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, aik@au1.ibm.com Alexey Kardashevskiy writes: > On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote: >> PAPR compliant guest calls this in absence of kdump. After >> receiving this call qemu could trigger a guest dump. This guest dump >> can be used to analyse using crash tool. >> >> Signed-off-by: Nikunj A Dadhania >> --- >> hw/ppc/spapr_rtas.c | 34 ++++++++++++++++++++++++++++++++++ >> 1 file changed, 34 insertions(+) >> >> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c >> index ea4a2b2..5ed8a0e 100644 >> --- a/hw/ppc/spapr_rtas.c >> +++ b/hw/ppc/spapr_rtas.c >> @@ -29,6 +29,8 @@ >> #include "sysemu/char.h" >> #include "hw/qdev.h" >> #include "sysemu/device_tree.h" >> +#include "qapi/qmp/qjson.h" >> +#include "monitor/monitor.h" >> >> #include "hw/ppc/spapr.h" >> #include "hw/ppc/spapr_vio.h" >> @@ -267,6 +269,34 @@ static void rtas_ibm_set_system_parameter(PowerPCCPU *cpu, >> rtas_st(rets, 0, ret); >> } >> >> +static void rtas_ibm_os_term(PowerPCCPU *cpu, >> + sPAPREnvironment *spapr, >> + uint32_t token, uint32_t nargs, >> + target_ulong args, >> + uint32_t nret, target_ulong rets) > > Indentation is broken here, should be 1 char right to align to "(". Sure, will fix > >> +{ >> + target_ulong ret = 0; >> + QObject *data; >> + >> + data = qobject_from_jsonf("{ 'action': %s }", "pause"); >> + monitor_protocol_event(QEVENT_GUEST_PANICKED, data); >> + qobject_decref(data); >> + vm_stop(RUN_STATE_GUEST_PANICKED); >> + >> + rtas_st(rets, 0, ret); >> +} >> + >> +static void rtas_ibm_ext_os_term(PowerPCCPU *cpu, >> + sPAPREnvironment *spapr, >> + uint32_t token, uint32_t nargs, >> + target_ulong args, >> + uint32_t nret, target_ulong rets) > > Same here, shift 5 chars to the right Sure >> +{ >> + target_ulong ret = 0; >> + >> + rtas_st(rets, 0, ret); >> +} >> + >> static struct rtas_call { >> const char *name; >> spapr_rtas_fn fn; >> @@ -392,6 +422,10 @@ static void core_rtas_register_types(void) >> rtas_ibm_get_system_parameter); >> spapr_rtas_register("ibm,set-system-parameter", >> rtas_ibm_set_system_parameter); >> + spapr_rtas_register("ibm,os-term", >> + rtas_ibm_os_term); >> + spapr_rtas_register("ibm,extended-os-term", >> + rtas_ibm_ext_os_term); > > While we are here, why to wrap these two? You are right, will fix. Regards Nikunj