From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47617)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1WmO31-0003dv-Mv
	for qemu-devel@nongnu.org; Mon, 19 May 2014 09:56:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1WmO2v-0001jU-Os
	for qemu-devel@nongnu.org; Mon, 19 May 2014 09:56:11 -0400
Received: from oxygen.pond.sub.org ([2a01:4f8:201:233:1::3]:35522)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@pond.sub.org>) id 1WmO2v-0001jE-IV
	for qemu-devel@nongnu.org; Mon, 19 May 2014 09:56:05 -0400
Received: from blackfin.pond.sub.org (p5B32BA71.dip0.t-ipconnect.de
	[91.50.186.113])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(Client did not present a certificate)
	by oxygen.pond.sub.org (Postfix) with ESMTPSA id 22F3120E34
	for <qemu-devel@nongnu.org>; Mon, 19 May 2014 15:55:59 +0200 (CEST)
From: Markus Armbruster <armbru@redhat.com>
References: <1399858555-9672-1-git-send-email-famz@redhat.com>
	<1399858555-9672-3-git-send-email-famz@redhat.com>
Date: Mon, 19 May 2014 15:55:59 +0200
In-Reply-To: <1399858555-9672-3-git-send-email-famz@redhat.com> (Fam Zheng's
	message of "Mon, 12 May 2014 09:35:41 +0800")
Message-ID: <87mwedq3dc.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, hbrock@redhat.com, qemu-devel@nongnu.org, rjones@redhat.com, imain@redhat.com, stefanha@redhat.com, pbonzini@redhat.com

Fam Zheng <famz@redhat.com> writes:

> This adds the enum of all the operations that can be taken on a block
> device.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> Reviewed-by: Benoit Canet <benoit@irqsave.net>
> Reviewed-by: Jeff Cody <jcody@redhat.com>
> ---
>  include/block/block.h | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>
> diff --git a/include/block/block.h b/include/block/block.h
> index 467fb2b..ac3a69b 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -155,6 +155,25 @@ typedef struct BDRVReopenState {
>      void *opaque;
>  } BDRVReopenState;
>  
> +/*
> + * Block operation types
> + */
> +typedef enum BlockOpType {
> +    BLOCK_OP_TYPE_BACKUP_SOURCE,
> +    BLOCK_OP_TYPE_BACKUP_TARGET,
> +    BLOCK_OP_TYPE_CHANGE,
> +    BLOCK_OP_TYPE_COMMIT,
> +    BLOCK_OP_TYPE_DATAPLANE,
> +    BLOCK_OP_TYPE_DRIVE_DEL,
> +    BLOCK_OP_TYPE_EJECT,
> +    BLOCK_OP_TYPE_EXTERNAL_SNAPSHOT,
> +    BLOCK_OP_TYPE_INTERNAL_SNAPSHOT,
> +    BLOCK_OP_TYPE_INTERNAL_SNAPSHOT_DELETE,
> +    BLOCK_OP_TYPE_MIRROR,
> +    BLOCK_OP_TYPE_RESIZE,
> +    BLOCK_OP_TYPE_STREAM,
> +    BLOCK_OP_TYPE_MAX,
> +} BlockOpType;
>  
>  void bdrv_iostatus_enable(BlockDriverState *bs);
>  void bdrv_iostatus_reset(BlockDriverState *bs);

Observation, not objection: BLOCK_OP_TYPE_COMMIT,
BLOCK_OP_TYPE_INTERNAL_SNAPSHOT and
BLOCK_OP_TYPE_INTERNAL_SNAPSHOT_DELETE are not used in this series.