From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52072)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1W8r6s-0003ac-GT
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 07:52:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1W8r6l-0003yK-37
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 07:52:46 -0500
Received: from mail-qc0-f178.google.com ([209.85.216.178]:48061)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ncmike@ncultra.org>) id 1W8r6k-0003y5-Un
	for qemu-devel@nongnu.org; Thu, 30 Jan 2014 07:52:39 -0500
Received: by mail-qc0-f178.google.com with SMTP id m20so4757707qcx.23
	for <qemu-devel@nongnu.org>; Thu, 30 Jan 2014 04:52:38 -0800 (PST)
From: Mike Day <ncmike@ncultra.org>
In-Reply-To: <1391008794-18777-1-git-send-email-drjones@redhat.com>
References: <1391008794-18777-1-git-send-email-drjones@redhat.com>
Date: Thu, 30 Jan 2014 07:44:59 -0500
Message-ID: <87mwidvdtg.fsf@pixel.localdomain>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH v3] virtio: Introduce virtio-testdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andrew Jones <drjones@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@linaro.org


Andrew Jones <drjones@redhat.com> writes:

> This is a virtio version of hw/misc/debugexit and should evolve into a
> virtio version of pc-testdev. pc-testdev uses the PC's ISA bus, whereas
> this testdev can be plugged into a virtio-mmio transport, which is
> needed for kvm-unit-tests/arm. virtio-testdev uses the virtio device
> config space as a communication channel, and implements an RTAS-like
> protocol through it allowing guests to execute commands. Only three
> commands are currently implemented;
> 1) VERSION: for version compatibility checks
> 2) CLEAR:   set all the config space back to zero
> 3) EXIT:    exit() from qemu with a status code

> +static uint32_t virtio_testdev_get_features(VirtIODevice *vdev, uint32_t f)
> +{
> +    return f;
> +}
> +

Is this meant to be a stub currently? 

Mike

-- 
Mike Day | "Endurance is a Virtue"