All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
	Namhyung Kim <namhyung.kim@lge.com>,
	LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH 2/6] perf tools: Introduce struct perf_log
Date: Fri, 20 Dec 2013 10:28:10 +0900	[thread overview]
Message-ID: <87mwjwe2fp.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <20131219132806.GJ4819@ghostprotocols.net> (Arnaldo Carvalho de Melo's message of "Thu, 19 Dec 2013 10:28:06 -0300")

Hi Arnaldo,

On Thu, 19 Dec 2013 10:28:06 -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Dec 19, 2013 at 04:00:07PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>> 
>> Add new functions to save error messages in a temp file.  It'll be
>> used by some UI front-ends to see the messages.
>
> Do we really have to grow a logging facility like this? Can't we somehow
> openlog/syslog/closelog? Just a first gut reaction, continuing to read
> the series...

I'm not sure.  It's not really a logging facility - I just wanted a way to
save log messages somewhere in order to show them in a TUI window.  My
feeling is that it doesn't need to grow since perf is not a service or so..

Thanks,
Namhyung

  reply	other threads:[~2013-12-20  1:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19  7:00 [PATCHSET 0/6] perf tools: A couple of TUI improvements Namhyung Kim
2013-12-19  7:00 ` [PATCH 1/6] perf report: Use pr_*() functions if possible Namhyung Kim
2013-12-19 13:30   ` Arnaldo Carvalho de Melo
2013-12-20  1:32     ` Namhyung Kim
2013-12-19 13:31   ` Jiri Olsa
2013-12-20  1:36     ` Namhyung Kim
2013-12-19  7:00 ` [PATCH 2/6] perf tools: Introduce struct perf_log Namhyung Kim
2013-12-19 13:28   ` Arnaldo Carvalho de Melo
2013-12-20  1:28     ` Namhyung Kim [this message]
2013-12-19  7:00 ` [PATCH 3/6] perf tools: Get rid of a duplicate va_end() Namhyung Kim
2013-12-19 13:32   ` Jiri Olsa
2013-12-19 13:32   ` Arnaldo Carvalho de Melo
2014-01-12 18:32   ` [tip:perf/core] perf tools: Get rid of a duplicate va_end() in error reporting routine tip-bot for Namhyung Kim
2013-12-19  7:00 ` [PATCH 4/6] perf tools: Save message when pr_*() was called Namhyung Kim
2013-12-19  7:00 ` [PATCH 5/6] perf ui/tui: Implement log window Namhyung Kim
2013-12-19  7:00 ` [PATCH 6/6] perf ui/tui: Implement header window Namhyung Kim
2013-12-19 12:14 ` [PATCHSET 0/6] perf tools: A couple of TUI improvements Ingo Molnar
2013-12-20  1:20   ` Namhyung Kim
2013-12-19 13:39 ` Jiri Olsa
2013-12-19 15:51   ` Ingo Molnar
2013-12-19 15:53   ` Ingo Molnar
2013-12-20  1:21     ` Namhyung Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwjwe2fp.fsf@sejong.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=dsahern@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung.kim@lge.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.