From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hitoshi Mitake <mitake.hitoshi@gmail.com>
Subject: Re: [PATCH] add --bsopts flag, pass to bs_init()
Date: Sun, 20 Oct 2013 21:53:23 +0900
Message-ID: <87mwm485oc.wl%mitake.hitoshi@gmail.com>
References: <1381539243-13245-1-git-send-email-dan.mick@inktank.com>
	<5260965B.90002@inktank.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Return-path: <stgt-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=date:message-id:from:to:cc:subject:in-reply-to:references
         :user-agent:mime-version:content-type;
        bh=LA/PPSbT7kBAu8UyROPjEgsMO4xGxHaEvYQiRXh9WUw=;
        b=JxW7u7puWJdbjSRbexU61xawq5Gg2RTdoFogtRO2eB6jO8zNaDclE9NSxz5gRPQ/H2
         KEJvW0drNovAQHTIG2FRvGEMN2l1I6NG2RlWQTCmn08mq8M++hPo3+nVpnfxGBkMcZFf
         HqDGraKlYBUdbZ6B1Zhp/oGu0FlCzWZpxGo+fMW4uTM0WV1p3ob1pHLuMFreGnBrQ6vh
         izXBAav+n69OILWA3VUKWPoTu/m6UoOWci/64R3plC5hVGjFNuSFNTQ9KtWmDaj8vVS0
         Swo3r0uFLtaTYaDqGwa/TT8kEoCUwkfuU5tYta0UYYvW/2cjI0SQr7xGvNpCnC4ddI9J
         PBgA==
In-Reply-To: <5260965B.90002@inktank.com>
Sender: stgt-owner@vger.kernel.org
List-ID: <stgt.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Mick <dan.mick@inktank.com>
Cc: stgt@vger.kernel.org

At Thu, 17 Oct 2013 19:00:59 -0700,
Dan Mick wrote:
> 
> ping

I'd like to +1 this patch. It will be benefit of all backing stores.

Thanks,
Hitoshi

> 
> On 10/11/2013 05:54 PM, Dan Mick wrote:
> > This patch implements the generic mechanism of passing backing-store-
> > specific options to the backing store module's bs_init entry point.
> > Each backing-store module gets a new parameter, char *bsopts,
> > added to its bs_init.
> >
> > No semantics or even syntax are imposed on the option string, other
> > than that commas are not permitted, because tgtadm communicates to
> > tgtd using a block of key=val,key=val,key=val options, and there's
> > no provision for escaping commas.
> >
> > tgtadm.8 is updated as well
> >
> > Dan Mick (1):
> >    Add bsopts flag
> >
> >   doc/tgtadm.8.xml  |   20 +++++++++++++++++---
> >   scripts/tgt-admin |   13 ++++++++++++-
> >   usr/bs_aio.c      |    2 +-
> >   usr/bs_rbd.c      |    3 ++-
> >   usr/bs_rdwr.c     |    2 +-
> >   usr/bs_sg.c       |    2 +-
> >   usr/bs_sheepdog.c |    2 +-
> >   usr/bs_ssc.c      |    2 +-
> >   usr/spc.c         |    3 ++-
> >   usr/target.c      |   12 +++++++++---
> >   usr/tgtadm.c      |   18 +++++++++++++-----
> >   usr/tgtd.h        |    2 +-
> >   12 files changed, 61 insertions(+), 20 deletions(-)
> >
> --
> To unsubscribe from this list: send the line "unsubscribe stgt" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html