From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJP2o-0006hI-Bj for qemu-devel@nongnu.org; Tue, 10 Sep 2013 10:36:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VJP2i-0001xv-9V for qemu-devel@nongnu.org; Tue, 10 Sep 2013 10:35:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VJP2i-0001xj-11 for qemu-devel@nongnu.org; Tue, 10 Sep 2013 10:35:48 -0400 From: Juan Quintela In-Reply-To: <522F188B.7040808@redhat.com> (Paolo Bonzini's message of "Tue, 10 Sep 2013 15:03:07 +0200") References: <1378784607-7398-1-git-send-email-junqing.wang@cs2c.com.cn> <1378784607-7398-3-git-send-email-junqing.wang@cs2c.com.cn> <87eh8weq48.fsf@elfo.elfo> <522F188B.7040808@redhat.com> Date: Tue, 10 Sep 2013 18:37:53 +0200 Message-ID: <87mwnkd44e.fsf@elfo.elfo> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH RFC 2/4] Curling: cmdline interface Reply-To: quintela@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: stefanha@redhat.com, owasserm@redhat.com, Jules Wang , qemu-devel@nongnu.org Paolo Bonzini wrote: > Il 10/09/2013 15:57, Juan Quintela ha scritto: >>> > >>> > + if (strstart(uri, "curling:", &p)) { >>> > + ft_mode = true; >>> > + uri = p; >>> > + } >>> > + >> Syntax is at least weird: >> >> curling:tcp:foo:9999 >> >> curling+tcp:foo:9999 >> >> could be better? Suggestions folks? >> >> notice that we still need more things: tcp+tls should happen at some >> time soon. This is not related with this patch. >> > > I think for the outgoing side it should just be "migrate -f tcp:foo:9999". > > On the incoming side, perhaps you could have a different ID instead of > QEMU_VM_FILE_MAGIC, that triggers fault-tolerance mode automatically? > Then again it would be simply "-incoming tcp:foo:9999". Then how can you distingish between faultolerance and simple migration? You need to diferentiate on both sides. - outgoing side: you need to continue running after sending the whole state - incoming side: after receivinga lot, you apply it, and have to wait for the next one. It is a different thing to do, we need to tell qemu somehow. > Paolo