Re: [Qemu-devel] [PATCH 1/2] Make default boot order machine specific

[Anthony Liguori <aliguori@us.ibm.com>]

Alexander Graf <agraf@suse.de> writes:

> On 23.10.2012, at 12:09, Avik Sil wrote:
>
>> This patch makes default boot order machine specific instead of
>> set globally. The default boot order can be set per machine in
>> QEMUMachine default_machine_opts, or by the command line using
>> -machine <machine_name>,boot=<boot_devices>, or by standard -boot
>> option. This allows a machine to receive a NULL boot order when
>> -boot isn't used and take an appropriate action accordingly. This
>> helps machine boots from the devices as set in guest's non-volatile
>> memory location in case no boot order is provided by the user.
>> 
>> Signed-off-by: Avik Sil <aviksil@linux.vnet.ibm.com>
>> ---
>> hw/nseries.c      |  2 ++
>> hw/pc_piix.c      | 13 ++++++++++++-
>> hw/ppc_newworld.c |  1 +
>> hw/ppc_oldworld.c |  1 +
>> hw/ppc_prep.c     |  1 +
>> hw/sun4m.c        | 10 ++++++++++
>> hw/sun4u.c        |  3 +++
>
> That feels like too much magic for my taste. Can't we have some
> default macro (or even the explicit "cad" thing) that we push to
> _every_ machine description out there? The next patch to implement
> boot= for pseries would then remove this default value for the pseries
> machine.

I agree, having a default macro would avoid having to touch everything
again for the next addition.

Regards,

Anthony Liguori

>
> The way the patch works right now, the "make machine specific" patch indirectly also changes the behavior for a bunch of machines.
>
>
> Alex