Re: [PATCH 0/7] perf ui/browser: Add browser for perf script

[Namhyung Kim <namhyung@kernel.org>]

Hi, Feng

On Mon,  3 Sep 2012 16:14:26 +0800, Feng Tang wrote:
> Hi Arnaldo and all,
>
> This is a patch set mainly to add a browser for perf script, which
> will be integrated into the main hists and annotation browser.
>
> Patch 1-4 are some preparation for adding the script
> patch 5 introduce the script browser
> patch 6-7 integrate the browser to hists browser and annotation browser
>
> The patches are on top of current perf/core branch of your git tree. 
> Please help to review, thanks
>

There was a build failure on my F17 box:

      CC builtin-script.o
  builtin-script.c: In function ‘find_scripts’:
  builtin-script.c:1047:7: error: variable ‘first_half’ set but not used [-Werror=unused-but-set-variable]
  builtin-script.c:1046:22: error: variable ‘desc’ set but not used [-Werror=unused-but-set-variable]
  cc1: all warnings being treated as errors
  make: *** [builtin-script.o] Error 1

Thanks,
Namhyung


> Feng
> -----------------------
> Feng Tang (7):
>   perf symbols: Filter samples with unresolved symbol when "--symbols"
>     option is used
>   perf scripts: Add --symbols option to handle specific symbols
>   perf scripts: Add event_analyzing_sample-record/report
>   perf scripts: Export a find_scripts() function
>   perf ui/browser: Add a browser for perf script
>   perf ui/browser: Integrate script browser into annotation browser
>   perf ui/browser: Integrate script browser into main hists browser
>
>  tools/perf/Makefile                                |    5 +
>  tools/perf/builtin-script.c                        |   49 ++++++
>  tools/perf/builtin.h                               |    1 +
>  .../python/bin/event_analyzing_sample-record       |    8 +
>  .../python/bin/event_analyzing_sample-report       |    3 +
>  tools/perf/ui/browsers/annotate.c                  |    8 +
>  tools/perf/ui/browsers/hists.c                     |   39 +++++
>  tools/perf/ui/browsers/scripts.c                   |  159 ++++++++++++++++++++
>  tools/perf/ui/browsers/scripts.h                   |    5 +
>  tools/perf/util/event.c                            |    5 +-
>  10 files changed, 280 insertions(+), 2 deletions(-)
>  create mode 100644 tools/perf/scripts/python/bin/event_analyzing_sample-record
>  create mode 100644 tools/perf/scripts/python/bin/event_analyzing_sample-report
>  create mode 100644 tools/perf/ui/browsers/scripts.c
>  create mode 100644 tools/perf/ui/browsers/scripts.h