From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33705)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SuMfp-0005Xf-4e
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 07:56:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SuMfj-0005j6-Ul
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 07:56:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:19544)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1SuMfj-0005iw-N0
	for qemu-devel@nongnu.org; Thu, 26 Jul 2012 07:56:03 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1343235256-26310-1-git-send-email-lcapitulino@redhat.com>
	<1343235256-26310-11-git-send-email-lcapitulino@redhat.com>
Date: Thu, 26 Jul 2012 13:56:00 +0200
In-Reply-To: <1343235256-26310-11-git-send-email-lcapitulino@redhat.com> (Luiz
	Capitulino's message of "Wed, 25 Jul 2012 13:54:15 -0300")
Message-ID: <87mx2md9db.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 10/11] qerror: switch to qapi generated
	error macros and table
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, mdroth@linux.vnet.ibm.com

Luiz Capitulino <lcapitulino@redhat.com> writes:

> Previous commits added qapi infrastructure to automatically generate
> qerror macros and the qerror table from qapi-schema-errors.json.
>
> This commit drops the current error macros from qerror.h and the error
> table from qerror.c and use the generated ones instead.
>
> Please, note that qapi-error.c is actually _included_ by qerror.c.
> This is hacky, but the alternative is to make the table private to
> qapi-error.c and generate functions to return table entries. I think that
> doesn't pay much off.

Functions?  Why can't you simply put

    const QErrorStringTable qerror_table[NUMBER_OF_ERRORS];

into qapi-errors.h?

With a literal number instead of NUMBER_OF_ERRORS.  If you suffer from
literal-phobia, you can also #define it instead.