From: Kevin Hilman <khilman@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Matt Porter <mporter@ti.com>, Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH] ARM: OMAP2+: gpmc-smsc911x: only register regulator for first instance
Date: Mon, 19 Mar 2012 14:39:12 -0700 [thread overview]
Message-ID: <87mx7c5kzj.fsf@ti.com> (raw)
In-Reply-To: <201203192118.09286.arnd@arndb.de> (Arnd Bergmann's message of "Mon, 19 Mar 2012 21:18:09 +0000")
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> writes:
> On Wednesday 07 March 2012, Kevin Hilman wrote:
>> commit e4b0b2cbbb (ARM: OMAP2+: gpmc-smsc911x: add required smsc911x
>> regulators) added regulators which are registered during
>> gpmc_smsc911x_init(). However, some platforms (OMAP3/Overo) have more
>> than one instance of the SMSC911x and result in attempting to register
>> the same regulator more than once which causes a panic().
>>
>> Fix this by only registering the regulator when the platform_data id
>> field is zero, indicating its the first instance.
>>
>> Cc: Matt Porter <mporter@ti.com>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>
> It seems that both Olof and I forgot to forward this one to Linus.
>
> If it's ok for you, I'll add it to the fixes branch for v3.4 now
> and mark it for backporting to v3.3-stable.
A slightly different version of this is already in linux-next as commit
bb60424af517d6e6148505fb5ef256caa91b5b43.
It was in your 'fixes' branch, and was merged by Olaf from Tony on 3/13:
Merge branch 'fix-smsc911x-regulator' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into fixes
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: gpmc-smsc911x: only register regulator for first instance
Date: Mon, 19 Mar 2012 14:39:12 -0700 [thread overview]
Message-ID: <87mx7c5kzj.fsf@ti.com> (raw)
In-Reply-To: <201203192118.09286.arnd@arndb.de> (Arnd Bergmann's message of "Mon, 19 Mar 2012 21:18:09 +0000")
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> writes:
> On Wednesday 07 March 2012, Kevin Hilman wrote:
>> commit e4b0b2cbbb (ARM: OMAP2+: gpmc-smsc911x: add required smsc911x
>> regulators) added regulators which are registered during
>> gpmc_smsc911x_init(). However, some platforms (OMAP3/Overo) have more
>> than one instance of the SMSC911x and result in attempting to register
>> the same regulator more than once which causes a panic().
>>
>> Fix this by only registering the regulator when the platform_data id
>> field is zero, indicating its the first instance.
>>
>> Cc: Matt Porter <mporter@ti.com>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
>
> It seems that both Olof and I forgot to forward this one to Linus.
>
> If it's ok for you, I'll add it to the fixes branch for v3.4 now
> and mark it for backporting to v3.3-stable.
A slightly different version of this is already in linux-next as commit
bb60424af517d6e6148505fb5ef256caa91b5b43.
It was in your 'fixes' branch, and was merged by Olaf from Tony on 3/13:
Merge branch 'fix-smsc911x-regulator' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into fixes
Kevin
next prev parent reply other threads:[~2012-03-19 21:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 0:39 [PATCH] ARM: OMAP2+: gpmc-smsc911x: only register regulator for first instance Kevin Hilman
2012-03-07 0:39 ` Kevin Hilman
2012-03-07 0:44 ` Tony Lindgren
2012-03-07 0:44 ` Tony Lindgren
2012-03-07 1:39 ` Kevin Hilman
2012-03-07 1:39 ` Kevin Hilman
2012-03-07 2:28 ` Tony Lindgren
2012-03-07 2:28 ` Tony Lindgren
2012-03-19 21:18 ` Arnd Bergmann
2012-03-19 21:18 ` Arnd Bergmann
2012-03-19 21:39 ` Kevin Hilman [this message]
2012-03-19 21:39 ` Kevin Hilman
2012-03-19 22:09 ` Arnd Bergmann
2012-03-19 22:09 ` Arnd Bergmann
2012-03-19 22:48 ` Tony Lindgren
2012-03-19 22:48 ` Tony Lindgren
2012-03-20 8:20 ` Arnd Bergmann
2012-03-20 8:20 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx7c5kzj.fsf@ti.com \
--to=khilman@ti.com \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@ti.com \
--cc=olof@lixom.net \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.