From: Thomas Rast <trast@inf.ethz.ch>
To: Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>
Cc: <git@vger.kernel.org>, <peff@peff.net>,
<sam.vilain@catalyst.net.nz>, <sam@vilain.net>
Subject: Re: [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set
Date: Tue, 28 Feb 2012 15:34:13 +0100 [thread overview]
Message-ID: <87mx8358nu.fsf@thomas.inf.ethz.ch> (raw)
In-Reply-To: <4F4CEB5D.5020808@seap.minhap.es> (Nelson Benitez Leon's message of "Tue, 28 Feb 2012 15:57:33 +0100")
Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:
> On 02/28/2012 01:19 PM, Thomas Rast wrote:
>>
>> * Why is this needed? Does git's use of libcurl ignore http_proxy? [1]
>> seems to indicate that libcurl respects <protocol>_proxy
>> automatically.
>
> It could not be needed, because, as you noted, curl already reads it, but then we will
> loose the feature on patch [3/3] because if $http_proxy has username but no password
> curl will not ask you for the password.. instead if we read it we could detect that,
> and ask for the password.
Ok. An explanation along these lines should definitely go into the
commit message!
--
Thomas Rast
trast@{inf,student}.ethz.ch
next prev parent reply other threads:[~2012-02-28 14:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 12:54 [PATCH 2/3] http: try standard proxy env vars when http.proxy config option is not set Nelson Benitez Leon
2012-02-28 12:19 ` Thomas Rast
2012-02-28 14:57 ` Nelson Benitez Leon
2012-02-28 14:34 ` Thomas Rast [this message]
2012-02-28 19:24 ` Junio C Hamano
2012-02-29 10:38 ` Nelson Benitez Leon
2012-02-29 18:15 ` Junio C Hamano
2012-03-01 10:18 ` Nelson Benitez Leon
2012-03-04 19:19 ` Daniel Stenberg
2012-02-28 19:15 ` Jeff King
2012-02-28 19:27 ` Sam Vilain
2012-02-28 19:34 ` Jeff King
2012-02-29 9:55 ` Matthieu Moy
2012-02-29 10:46 ` Nelson Benitez Leon
2012-02-29 21:08 ` Jeff King
2012-03-01 9:57 ` Nelson Benitez Leon
2012-03-01 9:10 ` Jeff King
2012-03-11 16:56 ` James Cloos
2012-03-11 19:12 ` Junio C Hamano
2012-03-13 10:22 ` Nelson Benitez Leon
2012-03-14 4:36 ` Junio C Hamano
2012-03-14 9:54 ` Nelson Benitez Leon
2012-03-14 20:41 ` Junio C Hamano
2012-03-15 9:38 ` Nelson Benitez Leon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx8358nu.fsf@thomas.inf.ethz.ch \
--to=trast@inf.ethz.ch \
--cc=git@vger.kernel.org \
--cc=nelsonjesus.benitez@seap.minhap.es \
--cc=peff@peff.net \
--cc=sam.vilain@catalyst.net.nz \
--cc=sam@vilain.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.