From: Juan Quintela <quintela@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors
Date: Wed, 15 Feb 2012 14:15:05 +0100 [thread overview]
Message-ID: <87mx8kgrvq.fsf@elfo.elfo> (raw)
In-Reply-To: <1328902266-25308-6-git-send-email-lcapitulino@redhat.com> (Luiz Capitulino's message of "Fri, 10 Feb 2012 17:31:05 -0200")
Luiz Capitulino <lcapitulino@redhat.com> wrote:
> The Monitor object is passed back and forth within the migration/savevm
> code so that it can print errors and progress to the user.
>
> However, that approach assumes a HMP monitor, being completely invalid
> in QMP.
>
> This commit drops almost every single usage of the Monitor object, all
> monitor_printf() calls have been converted into DPRINTF() ones.
>
> There are a few remaining Monitor objects, those are going to be dropped
> by the next commit.
>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Basically only block-migration.c uses the monitor at all (rest of code
only pass around for block migration). Block migration don't work vey
well (to put it midly) at the moment.
I agree with removing the parameter, and also the info if that is
required.
Later, Juan.
next prev parent reply other threads:[~2012-02-15 13:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 19:31 [Qemu-devel] [PATCH 0/6] qapi: Convert migrate Luiz Capitulino
2012-02-10 19:31 ` [Qemu-devel] [PATCH 1/6] QError: Introduce new errors for the migration command Luiz Capitulino
2012-02-15 13:10 ` Juan Quintela
2012-02-10 19:31 ` [Qemu-devel] [PATCH 2/6] monitor: Introduce qemu_get_fd() Luiz Capitulino
2012-02-15 13:11 ` Juan Quintela
2012-02-10 19:31 ` [Qemu-devel] [PATCH 3/6] QDict: Introduce qdict_copy() Luiz Capitulino
2012-02-15 13:10 ` Juan Quintela
2012-02-15 17:01 ` Luiz Capitulino
2012-02-10 19:31 ` [Qemu-devel] [PATCH 4/6] Error: Introduce error_copy() Luiz Capitulino
2012-02-15 9:04 ` Paolo Bonzini
2012-02-15 13:05 ` Luiz Capitulino
2012-02-15 13:16 ` Paolo Bonzini
2012-02-15 13:27 ` Juan Quintela
2012-02-10 19:31 ` [Qemu-devel] [PATCH 5/6] Purge migration of (almost) everything to do with monitors Luiz Capitulino
2012-02-15 9:02 ` Jan Kiszka
2012-02-15 12:53 ` Luiz Capitulino
2012-02-15 13:32 ` Jan Kiszka
2012-02-15 13:15 ` Juan Quintela [this message]
2012-02-10 19:31 ` [Qemu-devel] [PATCH 6/6] qapi: Convert migrate Luiz Capitulino
2012-02-15 9:07 ` Wen Congyang
2012-02-15 13:06 ` Luiz Capitulino
2012-02-15 13:25 ` Juan Quintela
2012-02-15 16:01 ` Michael Roth
2012-02-15 17:13 ` Luiz Capitulino
2012-02-15 13:31 ` Jan Kiszka
2012-02-15 13:44 ` Jan Kiszka
2012-02-15 8:59 ` [Qemu-devel] [PATCH 0/6] " Jan Kiszka
2012-02-15 12:49 ` Luiz Capitulino
2012-02-15 13:34 ` Jan Kiszka
2012-02-15 17:23 ` Luiz Capitulino
2012-02-15 17:39 ` Jan Kiszka
2012-02-15 17:49 ` Luiz Capitulino
2012-02-15 17:56 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mx8kgrvq.fsf@elfo.elfo \
--to=quintela@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.