All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Tim Bird <tim.bird@am.sony.com>,
	Jason Wessel <jason.wessel@windriver.com>
Cc: David Decotigny <david.decotigny@google.com>,
	Kroah-Hartman <gregkh@suse.de>,
	Linus Walleij <linus.walleij@stericsson.com>,
	"Richard\@mail2.fw-bc.sony.com" <Richard@mail2.fw-bc.sony.com>,
	"linux-doc\@vger.kernel.org" <linux-doc@vger.kernel.org>,
	Lucas De Marchi <lucas.demarchi@profusion.mobi>,
	"kgdb-bugreport\@lists.sourceforge.net" 
	<kgdb-bugreport@lists.sourceforge.net>,
	Dmitry Torokhov <dtor@vmware.com>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Michal Schmidt <mschmidt@redhat.com>,
	"David\@mail2.fw-bc.sony.com" <David@mail2.fw-bc.sony.com>,
	Randy Dunlap <rdunlap@xenotime.net>,
	"Greg\@mail2.fw-bc.sony.com" <Greg@mail2.fw-bc.sony.com>,
	Satoru Moriya <satoru.moriya@hds.com>,
	Sievers <kay.sievers@vrfy.org>, Decotigny <decot@google.com>,
	"Kay\@mail2.fw-bc.sony.com" <Kay@mail2.fw-bc.sony.com>,
	Kennedy <richard@rsk.demon.co.uk>
Subject: Re: [Kgdb-bugreport] [PATCH v2 3/3] param: make /sys/module/*/paramaters optional
Date: Thu, 03 Nov 2011 08:21:30 +1030	[thread overview]
Message-ID: <87mxcetcpp.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4EB16EC3.8020209@am.sony.com>

On Wed, 2 Nov 2011 09:24:35 -0700, Tim Bird <tim.bird@am.sony.com> wrote:
> On 11/2/2011 6:30 AM, Jason Wessel wrote:
> > On 11/01/2011 06:50 PM, David Decotigny wrote:
> I would also like to see the size numbers.  However, to address
> Jason's concern, I think it's safe to assume that when someone is
> getting this aggressive with system size, they'll start leaving debug
> features on the floor (printk, kdb, etc.).  What would be appropriate,
> IMHO, would be to add a config dependency for kgdb/kdb and
> NOT resurrect /proc items.  There's work in progress in linux-tiny
> to tackle /proc configurability, and adding back /proc interfaces
> is likely to just have the issue resurface there.
>   -- Tim

This is already CONFIG_EXPERT; I don't think anyone really wants to turn
this off.

Yes, I think the patch comes from a false premise: that the reason that
people don't expost module params in sysfs is due to memory usage, and
that providing a way to turn that off will alleviate their fears.

So, my advice to David: just change the perms on any and all module
parameters you want.  *Then* if someone complains about bloat, you can
re-submit these patches and cc: me.

(BTW, don't like the first patch: static is nice, but keeping related
code together is nicer).

Cheers,
Rusty.

      reply	other threads:[~2011-11-03  0:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 23:50 [PATCH v2 0/3] param: optional /sys/module/*/parameters David Decotigny
2011-11-01 23:50 ` [PATCH v2 1/3] param: make destroy_params() private David Decotigny
2011-11-01 23:50 ` [PATCH v2 2/3] param: simple refactoring David Decotigny
2011-11-01 23:50 ` [PATCH v2 3/3] param: make /sys/module/*/paramaters optional David Decotigny
2011-11-02  0:24   ` Greg KH
2011-11-02 23:02     ` David Decotigny
2011-11-03  1:29       ` Greg KH
2011-11-02 13:30   ` Jason Wessel
2011-11-02 16:24     ` [Kgdb-bugreport] " Tim Bird
2011-11-02 21:51       ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxcetcpp.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=David@mail2.fw-bc.sony.com \
    --cc=Greg@mail2.fw-bc.sony.com \
    --cc=Kay@mail2.fw-bc.sony.com \
    --cc=Richard@mail2.fw-bc.sony.com \
    --cc=david.decotigny@google.com \
    --cc=decot@google.com \
    --cc=dtor@vmware.com \
    --cc=gregkh@suse.de \
    --cc=jason.wessel@windriver.com \
    --cc=kay.sievers@vrfy.org \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lucas.demarchi@profusion.mobi \
    --cc=mschmidt@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=richard@rsk.demon.co.uk \
    --cc=satoru.moriya@hds.com \
    --cc=tim.bird@am.sony.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.