From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754433Ab1FGDaz (ORCPT ); Mon, 6 Jun 2011 23:30:55 -0400 Received: from ozlabs.org ([203.10.76.45]:45813 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752979Ab1FGDay convert rfc822-to-8bit (ORCPT ); Mon, 6 Jun 2011 23:30:54 -0400 From: Rusty Russell To: richard -rw- weinberger Cc: Christian Dietrich , "Venkatesh Pallipadi \(Venki\)" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Avi Kivity , Marcelo Tosatti , Kevin Tian , Fengzhe Zhang , John Stultz , Lucas De Marchi , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lguest@lists.ozlabs.org, trivial@kernel.org Subject: Re: [PATCH 8/8] arch/x86: use printk_ratelimited instead of printk_ratelimit In-Reply-To: References: <874o43ii1m.fsf@rustcorp.com.au> User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1 (i686-pc-linux-gnu) Date: Tue, 07 Jun 2011 12:41:02 +0930 Message-ID: <87mxhugwu1.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Jun 2011 10:11:53 +0200, richard -rw- weinberger wrote: > On Mon, Jun 6, 2011 at 8:35 AM, Rusty Russell wrote: > > On Sat, 4 Jun 2011 17:37:04 +0200, Christian Dietrich wrote: > >> Since printk_ratelimit() shouldn't be used anymore (see comment in > >> include/linux/printk.h), replace it with printk_ratelimited. > > > > Acked-by: Rusty Russell (lguest part) > > > >> diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c > >> index db832fd..23a6eff 100644 > >> --- a/arch/x86/lguest/boot.c > >> +++ b/arch/x86/lguest/boot.c > >> @@ -56,6 +56,7 @@ > >>  #include > >>  #include > >>  #include > >> +#include > >>  #include > >>  #include > >>  #include > > > > Is this new include really needed?  The printk_ratelimited() definition > > is in printk.h... > > Yes. > printk_ratelimited() needs DEFINE_RATELIMIT_STATE() which is defined > in ratelimit.h. Yech. I'm assuming that making printk.h include ratelimit.h makes a nasty mess? Thanks, Rusty. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rusty Russell Subject: Re: [PATCH 8/8] arch/x86: use printk_ratelimited instead of printk_ratelimit Date: Tue, 07 Jun 2011 12:41:02 +0930 Message-ID: <87mxhugwu1.fsf@rustcorp.com.au> References: <874o43ii1m.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: lguest-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "Venkatesh Pallipadi \(Venki\)" , Kevin Tian , Marcelo Tosatti , trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lucas De Marchi , John Stultz , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Fengzhe Zhang , Christian Dietrich , Ingo Molnar , Avi Kivity , "H. Peter Anvin" , Thomas Gleixner To: richard -rw- weinberger Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org List-Id: kvm.vger.kernel.org T24gTW9uLCA2IEp1biAyMDExIDEwOjExOjUzICswMjAwLCByaWNoYXJkIC1ydy0gd2VpbmJlcmdl ciA8cmljaGFyZC53ZWluYmVyZ2VyQGdtYWlsLmNvbT4gd3JvdGU6Cj4gT24gTW9uLCBKdW4gNiwg MjAxMSBhdCA4OjM1IEFNLCBSdXN0eSBSdXNzZWxsIDxydXN0eUBydXN0Y29ycC5jb20uYXU+IHdy b3RlOgo+ID4gT24gU2F0LCA0IEp1biAyMDExIDE3OjM3OjA0ICswMjAwLCBDaHJpc3RpYW4gRGll dHJpY2ggPGNocmlzdGlhbi5kaWV0cmljaEBpbmZvcm1hdGlrLnVuaS1lcmxhbmdlbi5kZT4gd3Jv dGU6Cj4gPj4gU2luY2UgcHJpbnRrX3JhdGVsaW1pdCgpIHNob3VsZG4ndCBiZSB1c2VkIGFueW1v cmUgKHNlZSBjb21tZW50IGluCj4gPj4gaW5jbHVkZS9saW51eC9wcmludGsuaCksIHJlcGxhY2Ug aXQgd2l0aCBwcmludGtfcmF0ZWxpbWl0ZWQuCj4gPgo+ID4gQWNrZWQtYnk6IFJ1c3R5IFJ1c3Nl bGwgPHJ1c3R5QHJ1c3Rjb3JwLmNvbS5hdT4gKGxndWVzdCBwYXJ0KQo+ID4KPiA+PiBkaWZmIC0t Z2l0IGEvYXJjaC94ODYvbGd1ZXN0L2Jvb3QuYyBiL2FyY2gveDg2L2xndWVzdC9ib290LmMKPiA+ PiBpbmRleCBkYjgzMmZkLi4yM2E2ZWZmIDEwMDY0NAo+ID4+IC0tLSBhL2FyY2gveDg2L2xndWVz dC9ib290LmMKPiA+PiArKysgYi9hcmNoL3g4Ni9sZ3Vlc3QvYm9vdC5jCj4gPj4gQEAgLTU2LDYg KzU2LDcgQEAKPiA+PiDCoCNpbmNsdWRlIDxsaW51eC9sZ3Vlc3RfbGF1bmNoZXIuaD4KPiA+PiDC oCNpbmNsdWRlIDxsaW51eC92aXJ0aW9fY29uc29sZS5oPgo+ID4+IMKgI2luY2x1ZGUgPGxpbnV4 L3BtLmg+Cj4gPj4gKyNpbmNsdWRlIDxsaW51eC9yYXRlbGltaXQuaD4KPiA+PiDCoCNpbmNsdWRl IDxhc20vYXBpYy5oPgo+ID4+IMKgI2luY2x1ZGUgPGFzbS9sZ3Vlc3QuaD4KPiA+PiDCoCNpbmNs dWRlIDxhc20vcGFyYXZpcnQuaD4KPiA+Cj4gPiBJcyB0aGlzIG5ldyBpbmNsdWRlIHJlYWxseSBu ZWVkZWQ/IMKgVGhlIHByaW50a19yYXRlbGltaXRlZCgpIGRlZmluaXRpb24KPiA+IGlzIGluIHBy aW50ay5oLi4uCj4gCj4gWWVzLgo+IHByaW50a19yYXRlbGltaXRlZCgpIG5lZWRzIERFRklORV9S QVRFTElNSVRfU1RBVEUoKSB3aGljaCBpcyBkZWZpbmVkCj4gaW4gcmF0ZWxpbWl0LmguCgpZZWNo LiAgSSdtIGFzc3VtaW5nIHRoYXQgbWFraW5nIHByaW50ay5oIGluY2x1ZGUgcmF0ZWxpbWl0Lmgg bWFrZXMgYQpuYXN0eSBtZXNzPwoKVGhhbmtzLApSdXN0eS4KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGd1ZXN0IG1haWxpbmcgbGlzdApMZ3Vlc3RAbGlz dHMub3psYWJzLm9yZwpodHRwczovL2xpc3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGd1ZXN0Cg==