All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Mark Wu <dwu@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, Mark Wu <dwu@redhat.com>,
	Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index
Date: Thu, 02 Jun 2011 09:27:23 +0930	[thread overview]
Message-ID: <87mxi1xfz0.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1306913069-23637-1-git-send-email-dwu@redhat.com>

On Wed,  1 Jun 2011 03:24:29 -0400, Mark Wu <dwu@redhat.com> wrote:
> Current index allocation in virtio-blk is based on a monotonically
> increasing variable "index". It could cause some confusion about disk
> name in the case of hot-plugging disks. And it's impossible to find the
> lowest available index by just maintaining a simple index. So it's
> changed to use ida to allocate index via referring to the index
> allocation in scsi disk.
> 
> Signed-off-by: Mark Wu <dwu@redhat.com>

Hi Mark,

   I don't believe that we do disk probes in parallel, so the spinlock
is unnecessary.  Otherwise, this looks good.

Thanks,
Rusty.

  parent reply	other threads:[~2011-06-02  1:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01  7:24 [PATCH 1/1] [virt] virtio-blk: Use ida to allocate disk index Mark Wu
2011-06-01  8:25 ` Mark Wu
2011-06-02 10:34   ` Michael S. Tsirkin
2011-06-08 13:12     ` Mark Wu
2011-06-08 13:12     ` Mark Wu
2011-06-02 10:34   ` Michael S. Tsirkin
2011-06-01  8:25 ` Mark Wu
2011-06-01 23:57 ` Rusty Russell
2011-06-01 23:57 ` Rusty Russell [this message]
2011-06-08 13:08   ` Mark Wu
2011-06-08 13:08   ` Mark Wu
2011-06-08 23:21     ` Rusty Russell
2011-06-08 23:45       ` Greg KH
2011-06-08 23:45       ` Greg KH
2011-06-09  9:14       ` Tejun Heo
2011-06-09  9:14       ` Tejun Heo
2011-06-09 10:41         ` Mark Wu
2011-06-09 10:41         ` Mark Wu
2011-06-15  4:51           ` Rusty Russell
2011-06-15  4:51           ` Rusty Russell
2011-06-15  7:06             ` Tejun Heo
2011-06-16  0:05               ` Rusty Russell
2011-06-16  7:46                 ` Tejun Heo
2011-06-16  7:46                 ` Tejun Heo
2011-06-16  0:05               ` Rusty Russell
2011-06-15  7:06             ` Tejun Heo
2011-10-19 10:12           ` Michael S. Tsirkin
2011-10-24 10:02             ` Michael S. Tsirkin
2011-10-24 10:02               ` Jens Axboe
2011-10-25  1:07                 ` Rusty Russell
2011-06-08 23:21     ` Rusty Russell
2011-06-02 10:33 ` Michael S. Tsirkin
2011-06-02 10:33 ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2011-06-01  7:24 Mark Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxi1xfz0.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=axboe@kernel.dk \
    --cc=dwu@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.