From: Kevin Hilman <khilman@ti.com>
To: Lesly A M <leslyam@ti.com>
Cc: linux-omap@vger.kernel.org, Nishanth Menon <nm@ti.com>,
David Derrick <dderrick@ti.com>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v10 1/7] MFD: TWL4030: Fix for the TWL4030 sleep/wakeup sequence
Date: Fri, 13 May 2011 14:40:58 +0200 [thread overview]
Message-ID: <87mxiqg4dh.fsf@ti.com> (raw)
In-Reply-To: <1304687833-4578-2-git-send-email-leslyam@ti.com> (Lesly A. M.'s message of "Fri, 6 May 2011 18:47:07 +0530")
Lesly A M <leslyam@ti.com> writes:
> Only configure sleep script when the flag is TWL4030_SLEEP_SCRIPT.
>
> Adding the missing brackets for fixing the issue.
>
> Signed-off-by: Lesly A M <leslyam@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: David Derrick <dderrick@ti.com>
> Cc: Samuel Ortiz <sameo@linux.intel.com>
Acked-by: Kevin Hilman <khilman@ti.com>
> ---
> drivers/mfd/twl4030-power.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 6fed964..97f54ce 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -447,12 +447,13 @@ static int __init load_twl4030_script(struct twl4030_script *tscript,
> if (err)
> goto out;
> }
> - if (tscript->flags & TWL4030_SLEEP_SCRIPT)
> + if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> if (order)
> pr_warning("TWL4030: Bad order of scripts (sleep "\
> "script before wakeup) Leads to boot"\
> "failure on some boards\n");
> err = twl4030_config_sleep_sequence(address);
> + }
> out:
> return err;
> }
next prev parent reply other threads:[~2011-05-13 12:41 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 13:17 [PATCH v10 0/7] MFD: TWL4030: power script and workaround for erratum 27 Lesly A M
2011-05-06 13:17 ` [PATCH v10 1/7] MFD: TWL4030: Fix for the TWL4030 sleep/wakeup sequence Lesly A M
2011-05-13 12:40 ` Kevin Hilman [this message]
2011-05-13 17:14 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 2/7] MFD: TWL4030: Correct the warning print during script loading Lesly A M
2011-05-13 17:19 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 3/7] MFD: TWL4030: Modifying the macro name Main_Ref to all caps Lesly A M
2011-05-12 10:42 ` Tony Lindgren
2011-05-13 7:12 ` Manuel, Lesly Arackal
2011-05-13 17:20 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 4/7] MFD: TWL4030: power scripts for OMAP3 boards Lesly A M
2011-05-12 10:56 ` Tony Lindgren
2011-05-13 7:53 ` Manuel, Lesly Arackal
2011-05-13 18:39 ` Samuel Ortiz
2011-05-17 13:40 ` Manuel, Lesly Arackal
2011-05-22 21:40 ` Samuel Ortiz
2011-05-24 12:17 ` Manuel, Lesly Arackal
2011-06-02 18:29 ` Kevin Hilman
2011-06-06 14:03 ` Manuel, Lesly Arackal
2011-06-06 16:08 ` Kevin Hilman
2011-05-06 13:17 ` [PATCH v10 5/7] MFD: TWL4030: TWL version checking Lesly A M
2011-05-13 17:22 ` Samuel Ortiz
2011-05-06 13:17 ` [PATCH v10 6/7] MFD: TWL4030: workaround changes for Erratum 27 Lesly A M
2011-05-06 13:17 ` [PATCH v10 7/7] MFD: TWL4030: optimizing resource configuration Lesly A M
2011-06-02 15:36 ` [PATCH v10 0/7] MFD: TWL4030: power script and workaround for erratum 27 Steve Sakoman
2011-06-02 17:12 ` Steve Sakoman
2011-06-03 0:31 ` Kevin Hilman
2011-06-06 14:05 ` Manuel, Lesly Arackal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxiqg4dh.fsf@ti.com \
--to=khilman@ti.com \
--cc=dderrick@ti.com \
--cc=leslyam@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.