From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Hilman Subject: Re: [PATCH v8 6/7] omap3430: Updating the board file to use TWL4030 scripts Date: Mon, 07 Mar 2011 13:10:59 -0800 Message-ID: <87mxl64ows.fsf@ti.com> References: <1299072653-13414-1-git-send-email-leslyam@ti.com> <1299072653-13414-7-git-send-email-leslyam@ti.com> <87sjuy67l3.fsf@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from na3sys009aog103.obsmtp.com ([74.125.149.71]:58334 "EHLO na3sys009aog103.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756059Ab1CGVLI (ORCPT ); Mon, 7 Mar 2011 16:11:08 -0500 Received: by mail-pz0-f41.google.com with SMTP id 33so919597pzk.28 for ; Mon, 07 Mar 2011 13:11:02 -0800 (PST) In-Reply-To: <87sjuy67l3.fsf@ti.com> (Kevin Hilman's message of "Mon, 07 Mar 2011 11:42:16 -0800") Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Lesly A M Cc: linux-omap@vger.kernel.org, Nishanth Menon , David Derrick , Samuel Ortiz Kevin Hilman writes: > Lesly A M writes: > >> Using TWL4030 power scripts to control the LDOs and DCDC regulators >> while going to low power mode. >> >> Signed-off-by: Lesly A M > > Minor: Re: Subject: OMAP is an acronym, please capitalize. > >> Cc: Nishanth Menon >> Cc: David Derrick >> Cc: Samuel Ortiz >> --- >> arch/arm/mach-omap2/Makefile | 3 +- >> arch/arm/mach-omap2/board-3430sdp.c | 93 +---------------------------------- >> 2 files changed, 4 insertions(+), 92 deletions(-) >> >> diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile >> index 742ca67..bb11329 100644 >> --- a/arch/arm/mach-omap2/Makefile >> +++ b/arch/arm/mach-omap2/Makefile >> @@ -175,7 +175,8 @@ obj-$(CONFIG_MACH_OMAP3_PANDORA) += board-omap3pandora.o \ >> hsmmc.o >> obj-$(CONFIG_MACH_OMAP_3430SDP) += board-3430sdp.o \ >> hsmmc.o \ >> - board-flash.o >> + board-flash.o \ >> + twl4030.o > > This should not be board-specific in the Makefile, otherwise it will > have to be added for every single board that uses it. > > Rather, it should probably be built as long as CONFIG_TWL4030_POWER=y. > Also, please be sure to build test when that option is disabled as well. Just notcied that twl4030.c is already wrapped by CONFIG_TWL4030_POWER, so just build it for CONFIG_PM: diff --git a/arch/arm/mach-omap2/Makefile b/arch/arm/mach-omap2/Makefile index 65d8701..8bdc969 100644 --- a/arch/arm/mach-omap2/Makefile +++ b/arch/arm/mach-omap2/Makefile @@ -61,7 +61,7 @@ ifeq ($(CONFIG_PM),y) obj-$(CONFIG_ARCH_OMAP2) += pm24xx.o obj-$(CONFIG_ARCH_OMAP2) += sleep24xx.o pm_bus.o obj-$(CONFIG_ARCH_OMAP3) += pm34xx.o sleep34xx.o \ - cpuidle34xx.o pm_bus.o + cpuidle34xx.o pm_bus.o twl4030.o obj-$(CONFIG_ARCH_OMAP4) += pm44xx.o pm_bus.o obj-$(CONFIG_PM_DEBUG) += pm-debug.o obj-$(CONFIG_OMAP_SMARTREFLEX) += sr_device.o smartreflex.o Then, you'll also have to modify twl4030.h so that twl4030_generic_script is NULL when CONFIG_TWL_4030=n so board files will still compile. Kevin