Re: [PATCH 3/4] OMAP: Voltage: add ABB structures and data

[Kevin Hilman <khilman@ti.com>]

Hi Mike,

Mike Turquette <mturquette@ti.com> writes:

> OMAP3630 and OMAP4 support an Adaptive Body-Bias LDO on some voltage domains
> which effects voltage supplied to PMOS back-gates.  These LDOs have
> different operating modes which correspond to the voltage of each VDD.
>
> This patch introduces the data structures needed to represent the ABB LDOs
> in the voltage layer, and populates the appropriate data for 3630 and OMAP4.
> Note that OMAP34XX does not have this LDO, so any data for that chip has
> been initialized as zero.
>
> Signed-off-by: Mike Turquette <mturquette@ti.com>

This patch (and this series) should be updated based on Paul's split-up
of the voltage code & data series:

   http://marc.info/?l=linux-arm-kernel&m=129825439819340&w=2

> ---
>  arch/arm/mach-omap2/voltage.c             |  137 ++++++++++++++++++++++-------
>  arch/arm/plat-omap/include/plat/voltage.h |   28 ++++++
>  2 files changed, 133 insertions(+), 32 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/voltage.c b/arch/arm/mach-omap2/voltage.c
> index 0cbc58a..6ede092 100644
> --- a/arch/arm/mach-omap2/voltage.c
> +++ b/arch/arm/mach-omap2/voltage.c
> @@ -39,6 +39,10 @@
>  #define VP_TRANXDONE_TIMEOUT	300
>  #define VOLTAGE_DIR_SIZE	16
>  
> +#define ABB_TRANXDONE_TIMEOUT	30
> +#define FAST_OPP		0x1
> +#define NOMINAL_OPP		0x0
> +
>  static struct omap_vdd_info *vdd_info;
>  /*
>   * Number of scalable voltage domains.
> @@ -59,6 +63,17 @@ static struct omap_vdd_info omap3_vdd_info[] = {
>  		.voltdm = {
>  			.name = "mpu",
>  		},
> +		.abb = {
> +			.setup_offs	= OMAP3_PRM_LDO_ABB_SETUP_OFFSET,
> +			.ctrl_offs	= OMAP3_PRM_LDO_ABB_CTRL_OFFSET,
> +			.irqstatus_mpu_offs
> +					= OMAP3_PRM_IRQSTATUS_MPU_OFFSET,
> +			.done_st_shift	= OMAP3630_ABB_LDO_TRANXDONE_ST_SHIFT,
> +			.done_st_mask	= OMAP3630_ABB_LDO_TRANXDONE_ST_MASK,
> +			.configure	= NULL,
> +			.nb_handler	= NULL,
> +			.set_opp	= NULL,

NULL assignments are redundant.

[...]

Kevin