From: Kevin Hilman <khilman@deeprootsystems.com>
To: Nishanth Menon <nm@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Tony <tony@atomide.com>,
Thomas <thomas.petazzoni@free-electrons.com>
Subject: Re: [PATCH v4 2/3] omap4: opp: add OPP table data
Date: Mon, 22 Nov 2010 15:12:45 -0800 [thread overview]
Message-ID: <87mxp1kl5e.fsf@deeprootsystems.com> (raw)
In-Reply-To: <4CEAF45B.5050907@ti.com> (Nishanth Menon's message of "Mon, 22 Nov 2010 16:53:15 -0600")
Nishanth Menon <nm@ti.com> writes:
> Kevin Hilman wrote, on 11/22/2010 04:45 PM:
>>> static inline int omap3_opp_init(void)
>>> > {
>>> > return -EINVAL;
>>> > }
>>> > +static inline int omap4_opp_init(void)
>>> > +{
>>> > + return -EINVAL;
>>> > +}
>>> > #endif
>> Now that these are device_initcalls, seems like they can be made static
>> and not callable externally.
>
> how do we handle boards that need custom opp table modifications?
um..., er... ok, I was just testing to see if you were awake today. :/
Clearly I'm not remembering even my own feature suggestions. Sorry for
the noise. Guess I'm trying to review too many different series today.
Kevin
next prev parent reply other threads:[~2010-11-22 23:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH v3 1/3] omap: opp: add OMAP3 OPP table data and common init>
2010-11-16 18:54 ` [PATCH v4 0/3] OMAP: Add opp data Nishanth Menon
2010-11-16 18:54 ` [PATCH v4 1/3] omap: opp: add OMAP3 OPP table data and common init Nishanth Menon
2010-11-22 22:21 ` Kevin Hilman
2010-11-16 18:54 ` [PATCH v4 2/3] omap4: opp: add OPP table data Nishanth Menon
2010-11-22 22:45 ` Kevin Hilman
2010-11-22 22:53 ` Nishanth Menon
2010-11-22 23:12 ` Kevin Hilman [this message]
2010-11-22 23:19 ` Kevin Hilman
2010-11-22 23:30 ` Nishanth Menon
2010-11-23 0:09 ` Kevin Hilman
2010-11-23 15:19 ` Nishanth Menon
2010-11-23 20:38 ` Kevin Hilman
2010-11-23 22:33 ` Cousson, Benoit
2010-11-23 22:56 ` Nishanth Menon
2010-11-23 23:30 ` Cousson, Benoit
2010-11-24 0:16 ` Kevin Hilman
2010-11-24 2:34 ` Nishanth Menon
2010-11-16 18:54 ` [PATCH v3 3/3] OMAP3: remove OPP interfaces from OMAP PM layer Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxp1kl5e.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.