All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Hilman <khilman@deeprootsystems.com>
To: Silesh C V <silesh@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] OMAP: PM: CPUFREQ: Fix conditional compilation
Date: Wed, 29 Sep 2010 15:28:28 -0700	[thread overview]
Message-ID: <87mxr0rxpv.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1285752174-11394-1-git-send-email-silesh@ti.com> (Silesh C. V.'s message of "Wed, 29 Sep 2010 14:52:54 +0530")

Silesh C V <silesh@ti.com> writes:

> Fix conditional compilation. A conditional expresiion
> should follow "#elif", in this case #elif clause should
> check whether CONFIG_ARCH_OMAP3 is defined or not
> (ie. defined(CONFIG_ARCH_OMAP3)) rather than checking for
> the value of the macro.
>
> Signed-off-by: Silesh C V <silesh@ti.com>

OK, applied to the pm-cpufreq sub-branch of the PM branch.

Kevin

> ---
>  arch/arm/plat-omap/cpu-omap.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/cpu-omap.c b/arch/arm/plat-omap/cpu-omap.c
> index df08829..02e4865 100644
> --- a/arch/arm/plat-omap/cpu-omap.c
> +++ b/arch/arm/plat-omap/cpu-omap.c
> @@ -41,7 +41,7 @@ static struct cpufreq_frequency_table *freq_table;
>  
>  #ifdef CONFIG_ARCH_OMAP1
>  #define MPU_CLK		"mpu"
> -#elif CONFIG_ARCH_OMAP3
> +#elif defined(CONFIG_ARCH_OMAP3)
>  #define MPU_CLK		"arm_fck"
>  #else
>  #define MPU_CLK		"virt_prcm_set"

      reply	other threads:[~2010-09-29 22:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-29  9:22 [PATCH v2] OMAP: PM: CPUFREQ: Fix conditional compilation Silesh C V
2010-09-29 22:28 ` Kevin Hilman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxr0rxpv.fsf@deeprootsystems.com \
    --to=khilman@deeprootsystems.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=silesh@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.