From: Petr Rockai <prockai@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix vgremove to allow removal of VG with missing PVs.
Date: Wed, 30 Jun 2010 14:37:25 +0200 [thread overview]
Message-ID: <87mxuclmre.fsf@twilight.int.mornfall.net.> (raw)
In-Reply-To: <1277897478-15448-1-git-send-email-mbroz@redhat.com> (Milan Broz's message of "Wed, 30 Jun 2010 13:31:18 +0200")
Hi,
Milan Broz <mbroz@redhat.com> writes:
> diff --git a/WHATS_NEW b/WHATS_NEW
> index 0c415a3..b485a59 100644
> --- a/WHATS_NEW
> +++ b/WHATS_NEW
> @@ -1,5 +1,6 @@
> Version 2.02.69 -
> ================================
> + Fix vgremove to allow removal of VG with missing PVs. (2.02.52)
> Add {pv|vg}_mda_used_count which displays a count of mdas w/ignored bit clear.
> Add vg_mda_copies which displays the value of --vgmetadatacopies.
> Describe --vgmetadatacopies in lvm.conf and other man pages.
> diff --git a/test/t-activate-partial.sh b/test/t-activate-partial.sh
> index f0a95c5..15f5965 100644
> --- a/test/t-activate-partial.sh
> +++ b/test/t-activate-partial.sh
> @@ -15,3 +15,6 @@ lvchange -v --refresh --partial $vg/mirror
> # also check that vgchange works
> vgchange -a n --partial $vg
> vgchange -a y --partial $vg
> +
> +# check vgremove
> +vgremove -f $vg
> \ No newline at end of file
> diff --git a/tools/vgremove.c b/tools/vgremove.c
> index b719ca2..56e18ef 100644
> --- a/tools/vgremove.c
> +++ b/tools/vgremove.c
> @@ -49,7 +49,7 @@ static int vgremove_single(struct cmd_context *cmd, const char *vg_name,
> }
> }
>
> - if (!vg_remove_check(vg)) {
> + if (!force && !vg_remove_check(vg)) {
> stack;
> return ECMD_FAILED;
> }
Looks OK as far as I can tell. Maybe just add "not vgremove $vg" just
before "vgremove -f $vg" in the test.
Yours,
Petr.
next prev parent reply other threads:[~2010-06-30 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 11:31 [PATCH] Fix vgremove to allow removal of VG with missing PVs Milan Broz
2010-06-30 12:37 ` Petr Rockai [this message]
2010-06-30 12:44 ` Milan Broz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxuclmre.fsf@twilight.int.mornfall.net. \
--to=prockai@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.