From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Munegowda, Keshava" <keshava_mgowda@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"tony@atomide.com" <tony@atomide.com>
Subject: Re: [PATCH]omap: mux.c warning removal
Date: Wed, 05 May 2010 14:21:40 -0700 [thread overview]
Message-ID: <87mxwe3uzf.fsf@deeprootsystems.com> (raw)
In-Reply-To: <0680EC522D0CC943BC586913CF3768C003B31651B1@dbde02.ent.ti.com> (Keshava Munegowda's message of "Wed\, 5 May 2010 19\:14\:08 +0530")
"Munegowda, Keshava" <keshava_mgowda@ti.com> writes:
> From: Keshava Munegowda <a0393220@ti.com>
>
> This patch removes the below warning
> arch/arm/mach-omap2/mux.c:52: warning: 'mux_phys' defined but not used
> The definition of variable mux_phys should be enclosed in the macro CONFIG_ARCH_OMAP3
>
> Signed-off-by: Keshava Munegowda <a0393220@ti.com>
> Index: linux-2.6/arch/arm/mach-omap2/mux.c
> ===================================================================
> --- linux-2.6.orig/arch/arm/mach-omap2/mux.c 2010-05-05 05:28:47.000000000 +0530
> +++ linux-2.6/arch/arm/mach-omap2/mux.c 2010-05-05 05:29:02.000000000 +0530
> @@ -49,7 +49,9 @@
> struct list_head node;
> };
>
> +#ifdef CONFIG_ARCH_OMAP3
> static unsigned long mux_phys;
> +#endif
Rather than add another #ifdef, just move this inside the existing
#ifdef farther down in the file.
Kevin
next prev parent reply other threads:[~2010-05-05 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 13:44 [PATCH]omap: mux.c warning removal Munegowda, Keshava
2010-05-05 21:21 ` Kevin Hilman [this message]
2010-05-06 6:36 ` Munegowda, Keshava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mxwe3uzf.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.