Re: [PATCH 1/6] vfs: add per-sb auxiliary inode attribute table

[Dmitry Monakhov <dmonakhov@openvz.org>]

Brad Boyer <flar@allandria.com> writes:

> On Thu, Feb 18, 2010 at 07:45:25PM +0300, Dmitry Monakhov wrote:
>> Some times it is useful to export non standard attributes
>> to generic vfs layer, but it is too expansive to store it
>> inside vfs inode. Let's introduce generic interface for this
>> purpose. One may declare an attribute and filesystem provides
>> access to it, if necessery.
>> 
>> Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
>> ---
>> @@ -1576,7 +1578,10 @@ struct super_operations {
>>  #endif
>>  	int (*bdev_try_to_free_page)(struct super_block*, struct page*, gfp_t);
>>  };
>> -
>> +struct aux_attributes
>> +{
>> +	int supported;
>> +};
>>  /*
>>   * Inode state bits.  Protected by inode_lock.
>>   *
>> -- 
>
> What is the intended use of the supported field? You don't appear to use
> it anywhere other than to initialize it to 1 in the one instance where
> you create one of them.
Actually i've use this only as a place holder, otherwise structure
will be empty. 
>
> 	Brad Boyer
> 	flar@allandria.com