Re: [PATCH] OMAP3: MMC: Add mux for pins

[Kevin Hilman <khilman@deeprootsystems.com>]

"Pandita, Vikram" <vikram.pandita@ti.com> writes:

>>
>>If some pins are always needed, and don't have alternative pinouts, then
>>the common pins could be muxed in devices.c.
>
> This is the algo we can use for MMC pin muxing in that case:
>
> MMC1: No pin has mux clash
> 	Mux all 10 pins in devices.c 

Is this common across 34xx and 35xx?

> MMC2: MUX CLK,CMD,D0-D3 in devices.c: D4-D7 have mux clash
> 	In case board needs 8 bit support,
> 	then in devices.c print KERN_WARNING "Configure MMC2:D4-D7 mux in board file"

I don't think you need a KERN_WARNING, what if the board code does this
later?  Probably a comment in the code would suffice.

> MMC3: All pins have mux clash: No mux done in devices.c
> 	In case board specifies MMC3 usage, 
> 	then in devices.c print KERN_WARNING "Configure MMC3 mux in board file"
>
> Let me know if this is final and I can submit a patch.

Kevin