All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Luis R. Rodriguez" <mcgrof@gmail.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Zhu Yi <yi.zhu@intel.com>
Subject: Re: Power saving on mac80211
Date: Sun, 19 Oct 2008 21:12:06 +0300	[thread overview]
Message-ID: <87myh0a1zd.fsf@nokia.com> (raw)
In-Reply-To: <1224434885.6324.49.camel@johannes.berg> (ext Johannes Berg's message of "Sun\, 19 Oct 2008 18\:48\:05 +0200")

Johannes Berg <johannes@sipsolutions.net> writes:

> On Sun, 2008-10-19 at 14:00 +0300, Kalle Valo wrote:
>
>> > Then add a new flag to mac80211 hw description that says "driver will
>> > watch beacons". This means that the code above that rearms the timer for
>> > the future 'nothing from AP' check is skipped.
>> 
>> I will. I need to check that if the "firmware beacon watch" is enabled
>> only when PSM is enabled. If it is, we might have to make the flag
>> dynamic.
>
> IIRC it's a separate flag.

Very good, that would be the best way.

>>  There isn't any
>> timeout for delivering beacons to the host, if the data path is idle
>> for 24 hours, mac80211 will not receive any beacons for the 24 hours.
>> I don't see why we need a timeout here.
>
> Right. But we need to program the chip to tell the chip "hey please tell
> me if you haven't seen a beacon in X seconds".

Ah, you mean that timeout. Sorry, I forgot that one altogether. Yes,
we definitely need that timeout.

>> I believe that there's also a feature in stlc4560 that the driver can
>> provide a checksum of the beacon and the firmware will send the beacon
>> if checksum doesn't match. But I don't yet know how that works in
>> practise.
>
> It seems to be a firmware feature, first beacon from the BSS the
> firmware computes the checksum, and if it changes it lets the beacon go
> through and re-computes the checksum, so you see all beacon changes.

So the driver doesn't have to compute any checksums itself? That makes
things easy then.

> Maybe it excludes the TIM.

It should. Otherwise beacon filtering in a crowded network with
clients in PSM would be next to useless. And I didn't see any major
increase in power consumption at Maemo Summit :)

> I think we want this for when the QoS parameters or something else
> changes.

Yeah. Just out of curiosity, are there any other parameters which
mac80211 needs to follow? Short preamble? Short slot time? Anything
else?

-- 
Kalle Valo

  reply	other threads:[~2008-10-19 18:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-18  1:10 Power saving on mac80211 Luis R. Rodriguez
2008-10-18  1:14 ` Luis R. Rodriguez
2008-10-18  1:45 ` Bob Copeland
2008-10-19  5:41 ` Kalle Valo
2008-10-19  7:24   ` Kalle Valo
2008-10-19 10:26     ` Johannes Berg
2008-10-19 11:00       ` Kalle Valo
2008-10-19 16:48         ` Johannes Berg
2008-10-19 18:12           ` Kalle Valo [this message]
2008-10-19 18:49             ` Johannes Berg
2008-10-20  1:46             ` Luis R. Rodriguez
2008-10-20  5:23               ` Kalle Valo
2008-10-20  6:34                 ` Luis R. Rodriguez
2008-10-20  6:15               ` Johannes Berg
2008-10-20  8:24                 ` Tomas Winkler
2008-10-20  5:23 ` Zhu Yi
2008-10-23  2:42 ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87myh0a1zd.fsf@nokia.com \
    --to=kalle.valo@nokia.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=mcgrof@gmail.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.