From: arno@natisbad.org (Arnaud Ebalard)
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ben.thery@gmail.com
Subject: Re: [PATCH,RESEND] XFRM,IPv6: initialize ip6_dst_blackhole_ops.kmem_cachep
Date: Wed, 01 Oct 2008 14:59:32 +0200 [thread overview]
Message-ID: <87myhozd1n.fsf@natisbad.org> (raw)
In-Reply-To: <20081001.023831.45381902.davem@davemloft.net> (David Miller's message of "Wed, 01 Oct 2008 02:38:31 -0700 (PDT)")
David Miller <davem@davemloft.net> writes:
> From: arno@natisbad.org (Arnaud Ebalard)
> Date: Wed, 01 Oct 2008 11:26:31 +0200
>
>> With the switch to a default value of 1 for xfrm_larval_drop in commit
>> 28faa979746b2352cd78a376bf9f52db953bda46 (ipsec: Make xfrm_larval_drop
>> default to 1), what seems to be a bug manage to surface on one of my
>> test box running today's net-next (*).
>>
>> When xfrm_tmpl_resolve() returns -EAGAIN in __xfrm_lookup(), the caller
>> is returned -EREMOTE and is expected to install a blackhole route. For
>> IPv6, the call to dst_alloc(&ip6_dst_blackhole_ops) performed by
>> ip6_dst_blackhole() produces the error provided below, because
>> kmem_cachep attribute seems to be uninitialized. This does not happen
>> when xfrm_larval_drop is set to 0.
>>
>> The patch below against today's net-next. Benjamin (in CC) reported on
>> the introduction of the bug (f2fc6a54585a1be6669613a31fbaba2ecbadcd36)
>> while adding network namespaces support to ipv6 routes.
>
> Applied to net-2.6, thanks Arnaud!
Can you queue it for -stable (2.6.26) too, if not already done?
a+
next prev parent reply other threads:[~2008-10-01 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-23 16:21 [PATCH] XFRM,IPv6: initialize ip6_dst_blackhole_ops.kmem_cachep Arnaud Ebalard
2008-09-25 9:21 ` Benjamin Thery
2008-09-25 9:38 ` Arnaud Ebalard
2008-10-01 9:26 ` [PATCH,RESEND] " Arnaud Ebalard
2008-10-01 9:38 ` David Miller
2008-10-01 12:59 ` Arnaud Ebalard [this message]
2008-10-01 13:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87myhozd1n.fsf@natisbad.org \
--to=arno@natisbad.org \
--cc=ben.thery@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.