From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/valgrind
Date: Mon, 16 Jun 2008 10:03:42 +0200 [thread overview]
Message-ID: <87myllhkm9.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20080616075421.GB19499@mx.loc> (Bernhard Fischer's message of "Mon\, 16 Jun 2008 09\:54\:21 +0200")
>>>>> "Bernhard" == Bernhard Fischer <rep.dot.nop@gmail.com> writes:
Hi,
>> Modified: trunk/buildroot/package/valgrind/valgrind.mk
>> ===================================================================
>> --- trunk/buildroot/package/valgrind/valgrind.mk 2008-06-15 20:44:05 UTC (rev 22359)
>> +++ trunk/buildroot/package/valgrind/valgrind.mk 2008-06-15 20:44:10 UTC (rev 22360)
>> @@ -64,6 +64,7 @@
-> cp package/valgrind/valgrind.sh $(TARGET_DIR)/usr/bin/valgrind
Bernhard> $(INSTALL)
Sure.
>> chmod a+x $(TARGET_DIR)/usr/bin/valgrind
>> rm -rf $(TARGET_DIR)/usr/share/doc/valgrind
>> + rm -rf $(TARGET_DIR)/usr/lib/pkgconfig
Bernhard> Removing all is a bit generic, no? Think about somebody selecting
Bernhard> pkgconfig for the target. If i would do this, i would expect
Bernhard> $(TARGET_DIR)/usr/lib/pkgconfig to be populated and useable..
But we don't have target support for pkgconfig.
>> #mkdir -p $(TARGET_DIR)/etc/default #cp
>> $(VALGRIND_DIR)/valgrind.default
>> $(TARGET_DIR)/etc/default/valgrind #mkdir -p
>> $(TARGET_DIR)/usr/lib/valgrind
Bernhard> cruft. Should have used $(INSTALL) -D
Bernhard> $(VALGRIND_DIR)/valgrind.default
Bernhard> $(TARGET_DIR)/etc/default/valgrind anyway.
Yes, I left it there as it's commented out anyway.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2008-06-16 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 20:44 [Buildroot] svn commit: trunk/buildroot/package/valgrind jacmet at uclibc.org
2008-06-16 7:54 ` Bernhard Fischer
2008-06-16 8:03 ` Peter Korsgaard [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-01 19:09 jacmet at uclibc.org
2008-06-15 20:44 jacmet at uclibc.org
2008-06-15 19:17 jacmet at uclibc.org
2007-07-05 15:55 jacmet at uclibc.org
2007-04-03 15:36 jacmet at uclibc.org
2006-09-25 8:48 jacmet at uclibc.org
2006-09-25 7:27 jacmet at uclibc.org
2006-08-10 20:21 andersen at uclibc.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87myllhkm9.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.