From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762433AbYD3KxQ (ORCPT ); Wed, 30 Apr 2008 06:53:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761897AbYD3Kwx (ORCPT ); Wed, 30 Apr 2008 06:52:53 -0400 Received: from saeurebad.de ([85.214.36.134]:54880 "EHLO saeurebad.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762264AbYD3Kww (ORCPT ); Wed, 30 Apr 2008 06:52:52 -0400 From: Johannes Weiner To: Ingo Molnar Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Andrew Morton , Thomas Gleixner , "H. Peter Anvin" , Yinghai Lu , Yinghai Lu , jbarnes@virtuousgeek.org Subject: Re: [patch] mm: node-setup agnostic free_bootmem() References: <20080426185516.GA32364@elte.hu> <20080426194143.GA8366@elte.hu> <87hcdmnccu.fsf@saeurebad.de> <20080427234630.GC14338@elte.hu> <877iein859.fsf@saeurebad.de> <20080428004046.GA16155@elte.hu> <87skx56i23.fsf@saeurebad.de> <20080429142520.GE26461@elte.hu> Date: Wed, 30 Apr 2008 12:52:48 +0200 In-Reply-To: <20080429142520.GE26461@elte.hu> (Ingo Molnar's message of "Tue, 29 Apr 2008 16:25:20 +0200") Message-ID: <87mynby5q7.fsf@saeurebad.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Ingo Molnar writes: > * Johannes Weiner wrote: > >> > void __init free_bootmem(unsigned long addr, unsigned long size) >> > { >> > bootmem_data_t *bdata; >> > - list_for_each_entry(bdata, &bdata_list, list) >> > - free_bootmem_core(bdata, addr, size); >> > + unsigned long pos = addr; >> > + unsigned long partsize = size; >> > + >> > + list_for_each_entry(bdata, &bdata_list, list) { >> > + unsigned long remainder = 0; >> > + >> > + if (pos < bdata->node_boot_start) >> > + continue; >> > + >> > + if (PFN_DOWN(pos + partsize) > bdata->node_low_pfn) { >> > + remainder = PFN_DOWN(pos + partsize) - bdata->node_low_pfn; >> > + partsize -= remainder; >> > + } >> > + >> > + free_bootmem_core(bdata, pos, partsize); >> > + >> > + if (!remainder) >> > + return; >> > + >> > + pos = PFN_PHYS(bdata->node_low_pfn + 1); >> > + } >> > + printk(KERN_ERR "free_bootmem: request: addr=%lx, size=%lx, " >> > + "state: pos=%lx, partsize=%lx\n", addr, size, >> > + pos, partsize); >> > + BUG(); >> > } >> > >> > unsigned long __init free_all_bootmem(void) >> >> Yes, looks good. But needs explicit testing, I guess. > > yep, but as Yinghai Lu has pointed it out, this removes a cross-node > allocation fix. That fix has to be preserved in any cleanup, agreed? Yes, if Yinghai is right, my patch should be dropped, of course. > in general bootmem should assume the weirdest of NUMA topologies and be > defensive about them. Topologies will only become more complex, never > less complex. Okay. Hannes